| Message ID | 1456302733-7053-1-git-send-email-a.hajda@samsung.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
Hi, Am 02/24/2016 um 09:32 AM schrieb Andrzej Hajda: > Bool variable 'fail' is always non-negative, it indicates an error if it > is true. > > The problem has been detected using coccinelle script > scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci > > Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> Acked-by: Alexander Aring <aar@pengutronix.de> Marcel, can you please apply this patch on bluetooth-next? Thanks. - Alex -- To unsubscribe from this list: send the line "unsubscribe linux-wpan" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Alex, > Bool variable 'fail' is always non-negative, it indicates an error if it > is true. > > The problem has been detected using coccinelle script > scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci > > Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> > --- > net/6lowpan/iphc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) patch has been applied to bluetooth-next tree. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-wpan" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/6lowpan/iphc.c b/net/6lowpan/iphc.c index d2a565c..0fe954f 100644 --- a/net/6lowpan/iphc.c +++ b/net/6lowpan/iphc.c @@ -482,7 +482,7 @@ static int lowpan_uncompress_multicast_ctx_daddr(struct sk_buff *skb, ipaddr->s6_addr[0] = 0xFF; fail = lowpan_fetch_skb(skb, &ipaddr->s6_addr[1], 2); fail |= lowpan_fetch_skb(skb, &ipaddr->s6_addr[12], 4); - if (fail < 0) + if (fail) return -EIO; /* take prefix_len and network prefix from the context */
Bool variable 'fail' is always non-negative, it indicates an error if it is true. The problem has been detected using coccinelle script scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> --- net/6lowpan/iphc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)