| Message ID | 1457633643-12535-3-git-send-email-web+oss@zopieux.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
Hello. On 10/03/16 19:14, web+oss@zopieux.com wrote: > From: Alexandre Macabies <web+oss@zopieux.com> > > We set the TXNSECEN bit of register TXNCON to on when transmitting a > security-enabled frame, as described in section 3.12.2 of the MRF > datasheet. SOB again. > Signed-off-by: Alexander Aring <aar@pengutronix.de> > Reported-by: Alexandre Macabies <web+oss@zopieux.com> > Tested-by: Alexandre Macabies <web+oss@zopieux.com> > --- > drivers/net/ieee802154/mrf24j40.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/net/ieee802154/mrf24j40.c b/drivers/net/ieee802154/mrf24j40.c > index 96814cf..bf11cbb 100644 > --- a/drivers/net/ieee802154/mrf24j40.c > +++ b/drivers/net/ieee802154/mrf24j40.c > @@ -61,6 +61,7 @@ > #define REG_TXBCON0 0x1A > #define REG_TXNCON 0x1B /* Transmit Normal FIFO Control */ > #define BIT_TXNTRIG BIT(0) > +#define BIT_TXNSECEN BIT(1) > #define BIT_TXNACKREQ BIT(2) > > #define REG_TXG1CON 0x1C > @@ -550,6 +551,9 @@ static void write_tx_buf_complete(void *context) > u8 val = BIT_TXNTRIG; > int ret; > > + if (ieee802154_is_secen(fc)) > + val |= BIT_TXNSECEN; > + > if (ieee802154_is_ackreq(fc)) > val |= BIT_TXNACKREQ; > Code looks fine. With the SOB fixed you get my: Reviewed-by: Stefan Schmidt <stefan@osg.samsung.com> regards Stefan Schmidt -- To unsubscribe from this list: send the line "unsubscribe linux-wpan" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ieee802154/mrf24j40.c b/drivers/net/ieee802154/mrf24j40.c index 96814cf..bf11cbb 100644 --- a/drivers/net/ieee802154/mrf24j40.c +++ b/drivers/net/ieee802154/mrf24j40.c @@ -61,6 +61,7 @@ #define REG_TXBCON0 0x1A #define REG_TXNCON 0x1B /* Transmit Normal FIFO Control */ #define BIT_TXNTRIG BIT(0) +#define BIT_TXNSECEN BIT(1) #define BIT_TXNACKREQ BIT(2) #define REG_TXG1CON 0x1C @@ -550,6 +551,9 @@ static void write_tx_buf_complete(void *context) u8 val = BIT_TXNTRIG; int ret; + if (ieee802154_is_secen(fc)) + val |= BIT_TXNSECEN; + if (ieee802154_is_ackreq(fc)) val |= BIT_TXNACKREQ;