diff mbox

[RFC,bluetooth-next,01/19] ieee802154: cleanups for ieee802154.h

Message ID 1458652515-7862-2-git-send-email-aar@pengutronix.de (mailing list archive)
State Superseded
Headers show

Commit Message

Alexander Aring March 22, 2016, 1:14 p.m. UTC
This patch removes some const from non-pointer types and fixes the
function name for the ieee802154_is_valid_extended_unicast_addr
comment.

Signed-off-by: Alexander Aring <aar@pengutronix.de>
---
 include/linux/ieee802154.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Stefan Schmidt March 23, 2016, 9:59 a.m. UTC | #1
Hello.

On 22/03/16 14:14, Alexander Aring wrote:
> This patch removes some const from non-pointer types and fixes the
> function name for the ieee802154_is_valid_extended_unicast_addr
> comment.
>
> Signed-off-by: Alexander Aring<aar@pengutronix.de>
> ---
>   include/linux/ieee802154.h | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/linux/ieee802154.h b/include/linux/ieee802154.h
> index d3e4156..303f446 100644
> --- a/include/linux/ieee802154.h
> +++ b/include/linux/ieee802154.h
> @@ -260,17 +260,17 @@ static inline bool ieee802154_is_intra_pan(__le16 fc)
>    *
>    * @len: psdu len with (MHR + payload + MFR)
>    */
> -static inline bool ieee802154_is_valid_psdu_len(const u8 len)
> +static inline bool ieee802154_is_valid_psdu_len(u8 len)
>   {
>   	return (len == IEEE802154_ACK_PSDU_LEN ||
>   		(len >= IEEE802154_MIN_PSDU_LEN && len <= IEEE802154_MTU));
>   }
>   
>   /**
> - * ieee802154_is_valid_psdu_len - check if extended addr is valid
> + * ieee802154_is_valid_extended_unicast_addr - check if extended addr is valid
>    * @addr: extended addr to check
>    */
> -static inline bool ieee802154_is_valid_extended_unicast_addr(const __le64 addr)
> +static inline bool ieee802154_is_valid_extended_unicast_addr(__le64 addr)
>   {
>   	/* Bail out if the address is all zero, or if the group
>   	 * address bit is set.

Looks fine. This one does not need to wait for the rest of the patches 
to go in either.

Reviewed-by: Stefan Schmidt <stefan@osg.samsung.com>

regards
Stefan Schmidt
--
To unsubscribe from this list: send the line "unsubscribe linux-wpan" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/include/linux/ieee802154.h b/include/linux/ieee802154.h
index d3e4156..303f446 100644
--- a/include/linux/ieee802154.h
+++ b/include/linux/ieee802154.h
@@ -260,17 +260,17 @@  static inline bool ieee802154_is_intra_pan(__le16 fc)
  *
  * @len: psdu len with (MHR + payload + MFR)
  */
-static inline bool ieee802154_is_valid_psdu_len(const u8 len)
+static inline bool ieee802154_is_valid_psdu_len(u8 len)
 {
 	return (len == IEEE802154_ACK_PSDU_LEN ||
 		(len >= IEEE802154_MIN_PSDU_LEN && len <= IEEE802154_MTU));
 }
 
 /**
- * ieee802154_is_valid_psdu_len - check if extended addr is valid
+ * ieee802154_is_valid_extended_unicast_addr - check if extended addr is valid
  * @addr: extended addr to check
  */
-static inline bool ieee802154_is_valid_extended_unicast_addr(const __le64 addr)
+static inline bool ieee802154_is_valid_extended_unicast_addr(__le64 addr)
 {
 	/* Bail out if the address is all zero, or if the group
 	 * address bit is set.