diff mbox

[12/14] ieee802154: cc2520: use __func__ macro for debug messages

Message ID 20170922121405.31789-13-stefan@osg.samsung.com
State Accepted
Headers show

Commit Message

Stefan Schmidt Sept. 22, 2017, 12:14 p.m. UTC
Instead of having the function name hard-coded (it might change and we
forgot to update them in the debug output) we can use __func__ instead
and also shorter the line so we do not need to break it.
Found by checkpatch.

Signed-off-by: Stefan Schmidt <stefan@osg.samsung.com>
---
 drivers/net/ieee802154/cc2520.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

Comments

Stefan Schmidt Nov. 6, 2017, 3:23 p.m. UTC | #1
Hello Varka.

On 11/06/2017 04:04 PM, Varka Bhadram wrote:
> On Fri, Sep 22, 2017 at 5:44 PM, Stefan Schmidt <stefan@osg.samsung.com <mailto:stefan@osg.samsung.com>> wrote:
> 
>     Instead of having the function name hard-coded (it might change and we
>     forgot to update them in the debug output) we can use __func__ instead
>     and also shorter the line so we do not need to break it.
>     Found by checkpatch.
> 
>     Signed-off-by: Stefan Schmidt <stefan@osg.samsung.com>
>     ---
> 
>  Acked-by: varkabhadram@gmail.com 

Your acked-by line is missing your real name. I will fix it up for the three acks you just sent. Please keep it in mind for the next time
though :)

regards
Stefan Schmidt
--
To unsubscribe from this list: send the line "unsubscribe linux-wpan" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Stefan Schmidt Nov. 6, 2017, 3:34 p.m. UTC | #2
Hello.

On 22.09.2017 14:14, Stefan Schmidt wrote:
> Instead of having the function name hard-coded (it might change and we
> forgot to update them in the debug output) we can use __func__ instead
> and also shorter the line so we do not need to break it.
> Found by checkpatch.
> 
> Signed-off-by: Stefan Schmidt <stefan@osg.samsung.com>
> ---
>  drivers/net/ieee802154/cc2520.c | 10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/net/ieee802154/cc2520.c b/drivers/net/ieee802154/cc2520.c
> index 9c1d1768a36f..735b9f5f9754 100644
> --- a/drivers/net/ieee802154/cc2520.c
> +++ b/drivers/net/ieee802154/cc2520.c
> @@ -663,15 +663,14 @@ cc2520_filter(struct ieee802154_hw *hw,
>  	if (changed & IEEE802154_AFILT_PANID_CHANGED) {
>  		u16 panid = le16_to_cpu(filt->pan_id);
>  
> -		dev_vdbg(&priv->spi->dev,
> -			 "cc2520_filter called for pan id\n");
> +		dev_vdbg(&priv->spi->dev, "%s called for pan id\n", __func__);
>  		ret = cc2520_write_ram(priv, CC2520RAM_PANID,
>  				       sizeof(panid), (u8 *)&panid);
>  	}
>  
>  	if (changed & IEEE802154_AFILT_IEEEADDR_CHANGED) {
>  		dev_vdbg(&priv->spi->dev,
> -			 "cc2520_filter called for IEEE addr\n");
> +			 "%s called for IEEE addr\n", __func__);
>  		ret = cc2520_write_ram(priv, CC2520RAM_IEEEADDR,
>  				       sizeof(filt->ieee_addr),
>  				       (u8 *)&filt->ieee_addr);
> @@ -680,8 +679,7 @@ cc2520_filter(struct ieee802154_hw *hw,
>  	if (changed & IEEE802154_AFILT_SADDR_CHANGED) {
>  		u16 addr = le16_to_cpu(filt->short_addr);
>  
> -		dev_vdbg(&priv->spi->dev,
> -			 "cc2520_filter called for saddr\n");
> +		dev_vdbg(&priv->spi->dev, "%s called for saddr\n", __func__);
>  		ret = cc2520_write_ram(priv, CC2520RAM_SHORTADDR,
>  				       sizeof(addr), (u8 *)&addr);
>  	}
> @@ -690,7 +688,7 @@ cc2520_filter(struct ieee802154_hw *hw,
>  		u8 frmfilt0;
>  
>  		dev_vdbg(&priv->spi->dev,
> -			 "cc2520_filter called for panc change\n");
> +			 "%s called for panc change\n", __func__);
>  
>  		cc2520_read_register(priv, CC2520_FRMFILT0, &frmfilt0);
>  
> 

This patch has been applied to the wpan-next tree and will be
part of the next pull request to net-next. Thanks!

regards
Stefan Schmidt
--
To unsubscribe from this list: send the line "unsubscribe linux-wpan" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/net/ieee802154/cc2520.c b/drivers/net/ieee802154/cc2520.c
index 9c1d1768a36f..735b9f5f9754 100644
--- a/drivers/net/ieee802154/cc2520.c
+++ b/drivers/net/ieee802154/cc2520.c
@@ -663,15 +663,14 @@  cc2520_filter(struct ieee802154_hw *hw,
 	if (changed & IEEE802154_AFILT_PANID_CHANGED) {
 		u16 panid = le16_to_cpu(filt->pan_id);
 
-		dev_vdbg(&priv->spi->dev,
-			 "cc2520_filter called for pan id\n");
+		dev_vdbg(&priv->spi->dev, "%s called for pan id\n", __func__);
 		ret = cc2520_write_ram(priv, CC2520RAM_PANID,
 				       sizeof(panid), (u8 *)&panid);
 	}
 
 	if (changed & IEEE802154_AFILT_IEEEADDR_CHANGED) {
 		dev_vdbg(&priv->spi->dev,
-			 "cc2520_filter called for IEEE addr\n");
+			 "%s called for IEEE addr\n", __func__);
 		ret = cc2520_write_ram(priv, CC2520RAM_IEEEADDR,
 				       sizeof(filt->ieee_addr),
 				       (u8 *)&filt->ieee_addr);
@@ -680,8 +679,7 @@  cc2520_filter(struct ieee802154_hw *hw,
 	if (changed & IEEE802154_AFILT_SADDR_CHANGED) {
 		u16 addr = le16_to_cpu(filt->short_addr);
 
-		dev_vdbg(&priv->spi->dev,
-			 "cc2520_filter called for saddr\n");
+		dev_vdbg(&priv->spi->dev, "%s called for saddr\n", __func__);
 		ret = cc2520_write_ram(priv, CC2520RAM_SHORTADDR,
 				       sizeof(addr), (u8 *)&addr);
 	}
@@ -690,7 +688,7 @@  cc2520_filter(struct ieee802154_hw *hw,
 		u8 frmfilt0;
 
 		dev_vdbg(&priv->spi->dev,
-			 "cc2520_filter called for panc change\n");
+			 "%s called for panc change\n", __func__);
 
 		cc2520_read_register(priv, CC2520_FRMFILT0, &frmfilt0);