diff mbox

[06/14] ieee802154: atusb: fix some kernel coding style errors

Message ID 20170922121405.31789-7-stefan@osg.samsung.com
State Accepted
Headers show

Commit Message

Stefan Schmidt Sept. 22, 2017, 12:13 p.m. UTC
Fix a long line, wrong comment format and misaligned indent.

Signed-off-by: Stefan Schmidt <stefan@osg.samsung.com>
---
 drivers/net/ieee802154/atusb.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

Comments

Stefan Schmidt Nov. 6, 2017, 3:36 p.m. UTC | #1
Hello.

On 22.09.2017 14:13, Stefan Schmidt wrote:
> Fix a long line, wrong comment format and misaligned indent.
> 
> Signed-off-by: Stefan Schmidt <stefan@osg.samsung.com>
> ---
>  drivers/net/ieee802154/atusb.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ieee802154/atusb.c b/drivers/net/ieee802154/atusb.c
> index bb02e37257cf..13d8ee5df094 100644
> --- a/drivers/net/ieee802154/atusb.c
> +++ b/drivers/net/ieee802154/atusb.c
> @@ -841,7 +841,8 @@ static int atusb_get_and_show_revision(struct atusb *atusb)
>  
>  		dev_info(&usb_dev->dev,
>  			 "Firmware: major: %u, minor: %u, hardware type: %s (%d)\n",
> -			 atusb->fw_ver_maj, atusb->fw_ver_min, hw_name, atusb->fw_hw_type);
> +			 atusb->fw_ver_maj, atusb->fw_ver_min, hw_name,
> +			 atusb->fw_hw_type);
>  	}
>  	if (atusb->fw_ver_maj == 0 && atusb->fw_ver_min < 2) {
>  		dev_info(&usb_dev->dev,
> @@ -976,7 +977,8 @@ static int atusb_set_extended_addr(struct atusb *atusb)
>  	int ret;
>  
>  	/* Firmware versions before 0.3 do not support the EUI64_READ command.
> -	 * Just use a random address and be done */
> +	 * Just use a random address and be done.
> +	 */
>  	if (atusb->fw_ver_maj == 0 && atusb->fw_ver_min < 3) {
>  		ieee802154_random_extended_addr(&atusb->hw->phy->perm_extended_addr);
>  		return 0;
> @@ -1006,7 +1008,7 @@ static int atusb_set_extended_addr(struct atusb *atusb)
>  		atusb->hw->phy->perm_extended_addr = extended_addr;
>  		addr = swab64((__force u64)atusb->hw->phy->perm_extended_addr);
>  		dev_info(&usb_dev->dev, "Read permanent extended address %8phC from device\n",
> -			&addr);
> +			 &addr);
>  	}
>  
>  	kfree(buffer);
> 

This patch has been applied to the wpan-next tree and will be
part of the next pull request to net-next. Thanks!

regards
Stefan Schmidt
--
To unsubscribe from this list: send the line "unsubscribe linux-wpan" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/net/ieee802154/atusb.c b/drivers/net/ieee802154/atusb.c
index bb02e37257cf..13d8ee5df094 100644
--- a/drivers/net/ieee802154/atusb.c
+++ b/drivers/net/ieee802154/atusb.c
@@ -841,7 +841,8 @@  static int atusb_get_and_show_revision(struct atusb *atusb)
 
 		dev_info(&usb_dev->dev,
 			 "Firmware: major: %u, minor: %u, hardware type: %s (%d)\n",
-			 atusb->fw_ver_maj, atusb->fw_ver_min, hw_name, atusb->fw_hw_type);
+			 atusb->fw_ver_maj, atusb->fw_ver_min, hw_name,
+			 atusb->fw_hw_type);
 	}
 	if (atusb->fw_ver_maj == 0 && atusb->fw_ver_min < 2) {
 		dev_info(&usb_dev->dev,
@@ -976,7 +977,8 @@  static int atusb_set_extended_addr(struct atusb *atusb)
 	int ret;
 
 	/* Firmware versions before 0.3 do not support the EUI64_READ command.
-	 * Just use a random address and be done */
+	 * Just use a random address and be done.
+	 */
 	if (atusb->fw_ver_maj == 0 && atusb->fw_ver_min < 3) {
 		ieee802154_random_extended_addr(&atusb->hw->phy->perm_extended_addr);
 		return 0;
@@ -1006,7 +1008,7 @@  static int atusb_set_extended_addr(struct atusb *atusb)
 		atusb->hw->phy->perm_extended_addr = extended_addr;
 		addr = swab64((__force u64)atusb->hw->phy->perm_extended_addr);
 		dev_info(&usb_dev->dev, "Read permanent extended address %8phC from device\n",
-			&addr);
+			 &addr);
 	}
 
 	kfree(buffer);