| Message ID | 20240108181610.2697017-7-leitao@debian.org (mailing list archive) |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | None | expand |
Hello. On 08.01.24 19:16, Breno Leitao wrote: > W=1 builds now warn if module is built without a MODULE_DESCRIPTION(). > Add descriptions to ieee802154 modules. > > Signed-off-by: Breno Leitao <leitao@debian.org> > --- > net/ieee802154/6lowpan/core.c | 1 + > net/ieee802154/socket.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/net/ieee802154/6lowpan/core.c b/net/ieee802154/6lowpan/core.c > index 2c087b7f17c5..b88f6a96d961 100644 > --- a/net/ieee802154/6lowpan/core.c > +++ b/net/ieee802154/6lowpan/core.c > @@ -280,5 +280,6 @@ static void __exit lowpan_cleanup_module(void) > > module_init(lowpan_init_module); > module_exit(lowpan_cleanup_module); > +MODULE_DESCRIPTION("IPv6 over Low power Wireless Personal Area Network IEEE802154.4 core"); If we want to nitpick you could write it as IEEE 802.15.4. > MODULE_LICENSE("GPL"); > MODULE_ALIAS_RTNL_LINK("lowpan"); > diff --git a/net/ieee802154/socket.c b/net/ieee802154/socket.c > index 00302e8b9615..db8df6e26159 100644 > --- a/net/ieee802154/socket.c > +++ b/net/ieee802154/socket.c > @@ -1137,4 +1137,5 @@ module_init(af_ieee802154_init); > module_exit(af_ieee802154_remove); > > MODULE_LICENSE("GPL"); > +MODULE_DESCRIPTION("IEEE802154.4 socket interface"); > MODULE_ALIAS_NETPROTO(PF_IEEE802154); Same here. Besides this: Acked-by: Stefan Schmidt <stefan@datenfreihafen.org> regards Stefan Schmidt
On Tue, Jan 09, 2024 at 08:25:21AM +0100, Stefan Schmidt wrote: > Hello. > > On 08.01.24 19:16, Breno Leitao wrote: > > W=1 builds now warn if module is built without a MODULE_DESCRIPTION(). > > Add descriptions to ieee802154 modules. > > > > Signed-off-by: Breno Leitao <leitao@debian.org> > > --- > > net/ieee802154/6lowpan/core.c | 1 + > > net/ieee802154/socket.c | 1 + > > 2 files changed, 2 insertions(+) > > > > diff --git a/net/ieee802154/6lowpan/core.c b/net/ieee802154/6lowpan/core.c > > index 2c087b7f17c5..b88f6a96d961 100644 > > --- a/net/ieee802154/6lowpan/core.c > > +++ b/net/ieee802154/6lowpan/core.c > > @@ -280,5 +280,6 @@ static void __exit lowpan_cleanup_module(void) > > module_init(lowpan_init_module); > > module_exit(lowpan_cleanup_module); > > +MODULE_DESCRIPTION("IPv6 over Low power Wireless Personal Area Network IEEE802154.4 core"); > > If we want to nitpick you could write it as IEEE 802.15.4. Thanks. I will update.
Hi, stefan@datenfreihafen.org wrote on Tue, 9 Jan 2024 08:25:21 +0100: > Hello. > > On 08.01.24 19:16, Breno Leitao wrote: > > W=1 builds now warn if module is built without a MODULE_DESCRIPTION(). > > Add descriptions to ieee802154 modules. > > > > Signed-off-by: Breno Leitao <leitao@debian.org> > > --- > > net/ieee802154/6lowpan/core.c | 1 + > > net/ieee802154/socket.c | 1 + > > 2 files changed, 2 insertions(+) > > > > diff --git a/net/ieee802154/6lowpan/core.c b/net/ieee802154/6lowpan/core.c > > index 2c087b7f17c5..b88f6a96d961 100644 > > --- a/net/ieee802154/6lowpan/core.c > > +++ b/net/ieee802154/6lowpan/core.c > > @@ -280,5 +280,6 @@ static void __exit lowpan_cleanup_module(void) > > > module_init(lowpan_init_module); > > module_exit(lowpan_cleanup_module); > > +MODULE_DESCRIPTION("IPv6 over Low power Wireless Personal Area Network IEEE802154.4 core"); > > If we want to nitpick you could write it as IEEE 802.15.4. Also agreed, can you please post an update? Thanks, Miquèl
Hello Miquèl, On Wed, Jan 24, 2024 at 05:48:02PM +0100, Miquel Raynal wrote: > Hi, > > stefan@datenfreihafen.org wrote on Tue, 9 Jan 2024 08:25:21 +0100: > > > Hello. > > > > On 08.01.24 19:16, Breno Leitao wrote: > > > W=1 builds now warn if module is built without a MODULE_DESCRIPTION(). > > > Add descriptions to ieee802154 modules. > > > > > > Signed-off-by: Breno Leitao <leitao@debian.org> > > > --- > > > net/ieee802154/6lowpan/core.c | 1 + > > > net/ieee802154/socket.c | 1 + > > > 2 files changed, 2 insertions(+) > > > > > > diff --git a/net/ieee802154/6lowpan/core.c b/net/ieee802154/6lowpan/core.c > > > index 2c087b7f17c5..b88f6a96d961 100644 > > > --- a/net/ieee802154/6lowpan/core.c > > > +++ b/net/ieee802154/6lowpan/core.c > > > @@ -280,5 +280,6 @@ static void __exit lowpan_cleanup_module(void) > > > > module_init(lowpan_init_module); > > > module_exit(lowpan_cleanup_module); > > > +MODULE_DESCRIPTION("IPv6 over Low power Wireless Personal Area Network IEEE802154.4 core"); > > > > If we want to nitpick you could write it as IEEE 802.15.4. > > Also agreed, can you please post an update? Sure. I will send it soon, since I am splitting the patches in a set of 10. According to the maintainer's request: https://lore.kernel.org/all/20240122105708.52d33fa0@kernel.org/ For now, I am focusing on Ethernet drivers. Thanks!
diff --git a/net/ieee802154/6lowpan/core.c b/net/ieee802154/6lowpan/core.c index 2c087b7f17c5..b88f6a96d961 100644 --- a/net/ieee802154/6lowpan/core.c +++ b/net/ieee802154/6lowpan/core.c @@ -280,5 +280,6 @@ static void __exit lowpan_cleanup_module(void) module_init(lowpan_init_module); module_exit(lowpan_cleanup_module); +MODULE_DESCRIPTION("IPv6 over Low power Wireless Personal Area Network IEEE802154.4 core"); MODULE_LICENSE("GPL"); MODULE_ALIAS_RTNL_LINK("lowpan"); diff --git a/net/ieee802154/socket.c b/net/ieee802154/socket.c index 00302e8b9615..db8df6e26159 100644 --- a/net/ieee802154/socket.c +++ b/net/ieee802154/socket.c @@ -1137,4 +1137,5 @@ module_init(af_ieee802154_init); module_exit(af_ieee802154_remove); MODULE_LICENSE("GPL"); +MODULE_DESCRIPTION("IEEE802154.4 socket interface"); MODULE_ALIAS_NETPROTO(PF_IEEE802154);
W=1 builds now warn if module is built without a MODULE_DESCRIPTION(). Add descriptions to ieee802154 modules. Signed-off-by: Breno Leitao <leitao@debian.org> --- net/ieee802154/6lowpan/core.c | 1 + net/ieee802154/socket.c | 1 + 2 files changed, 2 insertions(+)