diff mbox series

[net-next,02/22] net: fill in MODULE_DESCRIPTION()s for ieee802154

Message ID 20240122184543.2501493-3-leitao@debian.org (mailing list archive)
State Handled Elsewhere
Headers show
Series None | expand

Commit Message

Breno Leitao Jan. 22, 2024, 6:45 p.m. UTC 
W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
Add descriptions to ieee802154 modules.

Signed-off-by: Breno Leitao <leitao@debian.org>
Acked-by: Stefan Schmidt <stefan@datenfreihafen.org>
---
 net/ieee802154/6lowpan/core.c | 1 +
 net/ieee802154/socket.c       | 1 +
 2 files changed, 2 insertions(+)

Comments

Miquel Raynal Jan. 24, 2024, 4:51 p.m. UTC | #1 
Hi Breno,

leitao@debian.org wrote on Mon, 22 Jan 2024 10:45:23 -0800:

> W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> Add descriptions to ieee802154 modules.
> 
> Signed-off-by: Breno Leitao <leitao@debian.org>
> Acked-by: Stefan Schmidt <stefan@datenfreihafen.org>

I just see the v2 now. Please use "v2" in your commit title using -v or
git-format-patch.

I'll take it through wpan.

Thanks,
Miquèl
Breno Leitao Jan. 25, 2024, 10:01 a.m. UTC | #2 
Hello Miquèl,

On Wed, Jan 24, 2024 at 05:51:58PM +0100, Miquel Raynal wrote:
> Hi Breno,
> 
> leitao@debian.org wrote on Mon, 22 Jan 2024 10:45:23 -0800:
> 
> > W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> > Add descriptions to ieee802154 modules.
> > 
> > Signed-off-by: Breno Leitao <leitao@debian.org>
> > Acked-by: Stefan Schmidt <stefan@datenfreihafen.org>
> 
> I just see the v2 now. Please use "v2" in your commit title using -v or
> git-format-patch.

Sorry, I am not sure I followed what you meant.  I've sent the v2, which
contains the 'v2' _tag_:

https://lore.kernel.org/all/20240123190332.677489-1-leitao@debian.org/

I didn't include the ieee802154 fix because the maintainers asked me to
split the patchset in a maximum of 10 patches[1], and I am doing it by
area (net, wifi, ethernet, etc). That means that this patch was not send
on the first batch, that is prioritizing Ethernet drivers (which is
described in the cover letter of v2)[2].

Anyway, let me know if I missed something here.

Thanks!
[1] https://lore.kernel.org/all/20240122105708.52d33fa0@kernel.org/
[2] https://lore.kernel.org/all/20240123190332.677489-1-leitao@debian.org/
Miquel Raynal Jan. 25, 2024, 2:55 p.m. UTC | #3 
Hi Breno,

leitao@debian.org wrote on Thu, 25 Jan 2024 02:01:06 -0800:

> Hello Miquèl,
> 
> On Wed, Jan 24, 2024 at 05:51:58PM +0100, Miquel Raynal wrote:
> > Hi Breno,
> > 
> > leitao@debian.org wrote on Mon, 22 Jan 2024 10:45:23 -0800:
> >   
> > > W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> > > Add descriptions to ieee802154 modules.
> > > 
> > > Signed-off-by: Breno Leitao <leitao@debian.org>
> > > Acked-by: Stefan Schmidt <stefan@datenfreihafen.org>  
> > 
> > I just see the v2 now. Please use "v2" in your commit title using -v or
> > git-format-patch.  
> 
> Sorry, I am not sure I followed what you meant.  I've sent the v2, which
> contains the 'v2' _tag_:

I believe *this* is a v2 because you fixed your initial patch,
following Stefan's suggestion.

Anyway, it's fine for me to merge this patch through net directly (I
don't know if net maintainers want W=1 fixes to go through net or
net-next) so:

Acked-by: Miquel Raynal <miquel.raynal@bootlin.com>

Thanks,
Miquèl
Breno Leitao Jan. 25, 2024, 3:36 p.m. UTC | #4 
On Thu, Jan 25, 2024 at 03:55:32PM +0100, Miquel Raynal wrote:
> Hi Breno,
> 
> leitao@debian.org wrote on Thu, 25 Jan 2024 02:01:06 -0800:
> 
> > Hello Miquèl,
> > 
> > On Wed, Jan 24, 2024 at 05:51:58PM +0100, Miquel Raynal wrote:
> > > Hi Breno,
> > > 
> > > leitao@debian.org wrote on Mon, 22 Jan 2024 10:45:23 -0800:
> > >   
> > > > W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> > > > Add descriptions to ieee802154 modules.
> > > > 
> > > > Signed-off-by: Breno Leitao <leitao@debian.org>
> > > > Acked-by: Stefan Schmidt <stefan@datenfreihafen.org>  
> > > 
> > > I just see the v2 now. Please use "v2" in your commit title using -v or
> > > git-format-patch.  
> > 
> > Sorry, I am not sure I followed what you meant.  I've sent the v2, which
> > contains the 'v2' _tag_:
> 
> I believe *this* is a v2 because you fixed your initial patch,
> following Stefan's suggestion.
> 
> Anyway, it's fine for me to merge this patch through net directly (I
> don't know if net maintainers want W=1 fixes to go through net or
> net-next) so:

Thanks Miquèl. Jakub convinced Paolo that these fixes should go through
net, that is why I am targeting `net`.

https://lore.kernel.org/all/20240122105708.52d33fa0@kernel.org/
diff mbox series

Patch

diff --git a/net/ieee802154/6lowpan/core.c b/net/ieee802154/6lowpan/core.c
index 2c087b7f17c5..e643f52663f9 100644
--- a/net/ieee802154/6lowpan/core.c
+++ b/net/ieee802154/6lowpan/core.c
@@ -280,5 +280,6 @@  static void __exit lowpan_cleanup_module(void)
 
 module_init(lowpan_init_module);
 module_exit(lowpan_cleanup_module);
+MODULE_DESCRIPTION("IPv6 over Low power Wireless Personal Area Network IEEE 802.15.4 core");
 MODULE_LICENSE("GPL");
 MODULE_ALIAS_RTNL_LINK("lowpan");
diff --git a/net/ieee802154/socket.c b/net/ieee802154/socket.c
index 00302e8b9615..990a83455dcf 100644
--- a/net/ieee802154/socket.c
+++ b/net/ieee802154/socket.c
@@ -1137,4 +1137,5 @@  module_init(af_ieee802154_init);
 module_exit(af_ieee802154_remove);
 
 MODULE_LICENSE("GPL");
+MODULE_DESCRIPTION("IEEE 802.15.4 socket interface");
 MODULE_ALIAS_NETPROTO(PF_IEEE802154);