diff mbox

[RESEND] AXFS: fix incompatible type assignment warning in axfs_register_profiling_proc()

Message ID CAEtiSauWd+7uvJ=dOUfb+eOnaVJ81mmnSHssFehaqWdcL18BGw@mail.gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Aaditya Kumar March 5, 2013, 6:17 p.m. UTC
This patch fixes following compilation warning caused by
Commit-ID: a7e526129f6ea298513ef4ce7aa6db08fc069d14

fs/axfs/axfs_profiling.c: In function ‘axfs_register_profiling_proc’:
fs/axfs/axfs_profiling.c:399:23: warning: assignment from incompatible
pointer type [enabled by default]
fs/axfs/axfs_profiling.c:400:24: warning: assignment from incompatible
pointer type [enabled by default]

Signed-off-by: Aaditya Kumar <aaditya.kumar@ap.sony.com>

---
Dear Greg,

It seems this patch was missed when applying AXFS build failure fixes.
(In commit id f56dadc96c6e1693e2fbd0212872534f7229eb56).

I originally posted it at:
 http://lists.linuxfoundation.org/pipermail/ltsi-dev/2012-December/001121.html
---
 fs/axfs/axfs_profiling.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--
1.7.9.5

Comments

Greg KH April 8, 2013, 7:11 p.m. UTC | #1
On Tue, Mar 05, 2013 at 11:47:22PM +0530, Aaditya Kumar wrote:
> This patch fixes following compilation warning caused by
> Commit-ID: a7e526129f6ea298513ef4ce7aa6db08fc069d14
> 
> fs/axfs/axfs_profiling.c: In function ‘axfs_register_profiling_proc’:
> fs/axfs/axfs_profiling.c:399:23: warning: assignment from incompatible
> pointer type [enabled by default]
> fs/axfs/axfs_profiling.c:400:24: warning: assignment from incompatible
> pointer type [enabled by default]
> 
> Signed-off-by: Aaditya Kumar <aaditya.kumar@ap.sony.com>
> 
> ---
> Dear Greg,
> 
> It seems this patch was missed when applying AXFS build failure fixes.
> (In commit id f56dadc96c6e1693e2fbd0212872534f7229eb56).
> 
> I originally posted it at:
>  http://lists.linuxfoundation.org/pipermail/ltsi-dev/2012-December/001121.html

This patch has dos line-ends, and all tabs were converted to spaces,
making it impossible to apply.  Also, your From: address and your
signed-off-by: address do not match, making it impossible for me to
apply this patch.  Read Documentation/SubmittingPatches for how do this
this correctly.

Please fix your email client and resend it properly.

thanks,

greg k-h
diff mbox

Patch

diff --git a/fs/axfs/axfs_profiling.c b/fs/axfs/axfs_profiling.c
index 9e1741f..a1c1a40 100644
--- a/fs/axfs/axfs_profiling.c
+++ b/fs/axfs/axfs_profiling.c
@@ -182,7 +182,7 @@  out:

 }

-static ssize_t axfs_procfile_read(char *buffer,
+static int axfs_procfile_read(char *buffer,
                                  char **buffer_location,
                                  off_t offset, int buffer_length, int *eof,
                                  void *data)
@@ -261,7 +261,7 @@  static ssize_t axfs_procfile_read(char *buffer,
        return print_len;
 }

-static ssize_t axfs_procfile_write(struct file *file,
+static int axfs_procfile_write(struct file *file,
                                   const char *buffer, unsigned long count,
                                   void *data)
 {