From patchwork Wed Aug 29 12:17:13 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Motai.Hirotaka@aj.MitsubishiElectric.co.jp" X-Patchwork-Id: 10580199 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 33487175A for ; Wed, 29 Aug 2018 12:40:54 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 21BBE2B00A for ; Wed, 29 Aug 2018 12:40:54 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 15B582B00C; Wed, 29 Aug 2018 12:40:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 9D8B42B00A for ; Wed, 29 Aug 2018 12:40:53 +0000 (UTC) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 2BBB1CED; Wed, 29 Aug 2018 12:36:46 +0000 (UTC) X-Original-To: ltsi-dev@lists.linuxfoundation.org Delivered-To: ltsi-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 51E1FD1F for ; Wed, 29 Aug 2018 12:36:41 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mx06.melco.co.jp (mx06.melco.co.jp [192.218.140.146]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 8E98312E for ; Wed, 29 Aug 2018 12:36:37 +0000 (UTC) Received: from mr06.melco.co.jp (mr06 [133.141.98.164]) by mx06.melco.co.jp (Postfix) with ESMTP id 3C39A3A3283 for ; Wed, 29 Aug 2018 21:18:11 +0900 (JST) Received: from mr06.melco.co.jp (unknown [127.0.0.1]) by mr06.imss (Postfix) with ESMTP id 420l5H1J7tzRkBT for ; Wed, 29 Aug 2018 21:18:11 +0900 (JST) Received: from mf03_second.melco.co.jp (unknown [192.168.20.183]) by mr06.melco.co.jp (Postfix) with ESMTP id 420l5H10c2zRk5W for ; Wed, 29 Aug 2018 21:18:11 +0900 (JST) Received: from mf03.melco.co.jp (unknown [133.141.98.183]) by mf03_second.melco.co.jp (Postfix) with ESMTP id 420l5H0tNNzRk8v for ; Wed, 29 Aug 2018 21:18:11 +0900 (JST) Received: from JPN01-OS2-obe.outbound.protection.outlook.com (unknown [23.103.139.148]) by mf03.melco.co.jp (Postfix) with ESMTP id 420l5H0Q9bzRk38 for ; Wed, 29 Aug 2018 21:18:11 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mitsubishielectricgroup.onmicrosoft.com; s=selector1-mitsubishielectricgroup-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rOFmRqoyKc0DkJrwzhQu9DaDmAyZQOez6C/wPeNALsc=; b=H3F0e2CZhTe8jjPwp6iz3lL7R6sFNI1jTtzHUhCb+GLjm6sY8JNnxn70UI4T2EcSgfooZd0VfbgRDN24MVf8bj0d68wIDlXYneCx8R4KoE5dMiPGWL1bfqdH0FdEgprSTvD6dRcS0oOJFCbpvT9eufwkWtJQbYS6WeeMepaZbRw= Received: from TY1PR01MB1692.jpnprd01.prod.outlook.com (52.133.160.145) by TY1PR01MB1456.jpnprd01.prod.outlook.com (10.174.228.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1080.17; Wed, 29 Aug 2018 12:18:10 +0000 Received: from TY1PR01MB1692.jpnprd01.prod.outlook.com ([fe80::d04e:e6f6:c782:22fa]) by TY1PR01MB1692.jpnprd01.prod.outlook.com ([fe80::d04e:e6f6:c782:22fa%2]) with mapi id 15.20.1080.015; Wed, 29 Aug 2018 12:18:10 +0000 From: "Motai.Hirotaka@aj.MitsubishiElectric.co.jp" To: "ltsi-dev@lists.linuxfoundation.org" Thread-Topic: [LTSI-dev] [PATCH 54/54] tracing: Fix code comments in trace.c Thread-Index: AdQ/jUO24+TDTv0mQAmIK6j/6FqKPQ== Date: Wed, 29 Aug 2018 12:17:13 +0000 Deferred-Delivery: Wed, 29 Aug 2018 12:15:00 +0000 Message-ID: Accept-Language: ja-JP, en-US Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: x-melpop: 1 authentication-results: spf=none (sender IP is ) smtp.mailfrom=Motai.Hirotaka@aj.MitsubishiElectric.co.jp; x-originating-ip: [153.231.200.201] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; TY1PR01MB1456; 6:wmuw0YxukHn84pyeLJtZ7zjc31gNQ3fVx/20ZeoVrEysPQjx6FRGRtRvuL8y6HHA93Rjxpbp2reCtxZBPj1P6ecTz0LLc8DuwIx8nof4GuqnVnAt8qnn2xArOY/X+OVzH0qYLwuqOCiJJ2GxSzJ98DivVcyHoBv0XGDVZeP2OZCu9FHLnnkdYNomrxYOsWUkmt9FERmdh29CzvJL61/LtyCeFtJcqivm6kvQQYZ4x2YnFPHrQa3LbTWV0Thv9BN04t29IzPYOesYwfRG+a8RRJ1h7KA/3K/1460FCpeT8DUEIO65rPp38L465y0lbRzOzyIdzfcpYjtdz9tW+Xv/zhhUenJmMVAZXgYfA662bukA5nO5wFeDbW7XKAbvbOcoJ+5HnoKqT4N7iJTGCySq5bs1VJcFh4QUzvN3EyMus2w99VL/wl6XumGpmqn4ex1hpimB+fYzPXCfwVtG+cXqUA==; 5:Y3nm8ptx5eX/70PbnTDIzmqF+ymjZz/fdkuDURPQqUQh2KT4S/izXiE/kV756saIy4UrB4cmZi7iPxBhWs5rXoWK1areQA2Y+HGOpCznTrPz8snmEbjfJHAl0ntDXbh+ZRcuEgc113KAdvwmtzjECGysq+63QOeCoyxcGOPVg3k=; 7:W8C+wbdYw9dEDmFdTWpcrGYUIqdmjL7hS7qclNqRqrTuFE1DJBeWPAAuupcWPZvAzQhPwnIcVK5MQOu4H3Q+U9J/B6+DDeQh880xPuZ/uw4DrOTB71H6YvqlgpP3iy+ea5sWXrNt1fc88YBnuUOwSFp4OkF5iU3l6AOQ1bmvPZF5XxtckRZ0ItbplA+JyepWY4MQvFheODf8NE1Wc3jwJyKCFJEaeN3vQOM602SDCYTKoxDJmADcBIbJCaclRcSG x-ms-office365-filtering-correlation-id: 7f3765e2-cd4b-4dc1-ad0c-08d60da97c4d x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989137)(5600074)(711020)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:TY1PR01MB1456; x-ms-traffictypediagnostic: TY1PR01MB1456: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(42068640409301); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(93001095)(3231311)(944501410)(52105095)(149027)(150027)(6041310)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123562045)(201708071742011)(7699016); SRVR:TY1PR01MB1456; BCL:0; PCL:0; RULEID:; SRVR:TY1PR01MB1456; x-forefront-prvs: 077929D941 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(396003)(366004)(136003)(346002)(376002)(39860400002)(199004)(189003)(26005)(6116002)(3846002)(6506007)(5660300001)(6916009)(74316002)(99286004)(486006)(8676002)(476003)(106356001)(1857600001)(2351001)(105586002)(33656002)(68736007)(81166006)(7696005)(2900100001)(9686003)(186003)(81156014)(97736004)(102836004)(66066001)(7736002)(5640700003)(6436002)(55016002)(6306002)(53936002)(2501003)(478600001)(5250100002)(966005)(14454004)(72206003)(25786009)(316002)(86362001)(2906002)(8936002)(305945005)(74482002)(256004)(14444005); DIR:OUT; SFP:1102; SCL:1; SRVR:TY1PR01MB1456; H:TY1PR01MB1692.jpnprd01.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:0; MX:1; received-spf: None (protection.outlook.com: aj.MitsubishiElectric.co.jp does not designate permitted sender hosts) x-microsoft-antispam-message-info: JSW/8rKMFVn55yiCcGRfyT8uUhFt+7AiMw0+yTJFVCi6lXesln7lpyGIDFSuiyN+fhnJwatgYfWlFp11BXe6Yd3+6tr0hupJvN+IGlrEfSbPl1Jlcx7lKkz+mEmusyyY92vi1sNH3aOCnaFz/7bHpgRVLcFPEiqsP/yuCIHmHGBJ1uONCU/B6ZXuBjxlsVa4jqSIYdviIYW4ec3Y1VcRGq+KTtZaK7ByIp2sGEBKStk1apJsWwfHDLXPmsbepr2EzqDXp6/PezdRzATkArBqu/pubi+TwILtsi0mKCRs92ACMl0tCJTMFHK1tP+INtwcVrH0tEPP1mWwGneQ32d9+76FnDcyWMV2AgdGbD+lxg0= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: aj.MitsubishiElectric.co.jp X-MS-Exchange-CrossTenant-Network-Message-Id: 7f3765e2-cd4b-4dc1-ad0c-08d60da97c4d X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Aug 2018 12:17:22.6527 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: c5a75b62-4bff-4c96-a720-6621ce9978e5 X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY1PR01MB1456 Subject: [LTSI-dev] [PATCH 54/54] tracing: Fix code comments in trace.c X-BeenThere: ltsi-dev@lists.linuxfoundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: "A list to discuss patches, development, and other things related to the LTSI project" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: ltsi-dev-bounces@lists.linuxfoundation.org Errors-To: ltsi-dev-bounces@lists.linuxfoundation.org X-Virus-Scanned: ClamAV using ClamSMTP Naming in code comments for tracing_snapshot, tracing_snapshot_alloc and trace_pid_filter_add_remove_task don't match the real function names. And latency_trace has been removed from tracing directory. Fix them. Link: http://lkml.kernel.org/r/1508394753-20887-1-git-send-email-chuhu@redhat.com Fixes: cab5037 ("tracing/ftrace: Enable snapshot function trigger") Fixes: 886b5b7 ("tracing: remove /debug/tracing/latency_trace") Signed-off-by: Chunyu Hu [ Replaced /sys/kernel/debug/tracing with /sys/kerne/tracing ] Signed-off-by: Steven Rostedt (VMware) (cherry picked from commit 5a93bae2c382c588f437ce0395e8032ae287dc36) Signed-off-by: Hirotaka MOTAI --- kernel/trace/trace.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index 25244e4e..61fe2d55 100644 --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c @@ -357,17 +357,17 @@ trace_ignore_this_task(struct trace_pid_list *filtered_pids, struct task_struct */ if (!filtered_pids) return false; return !trace_find_filtered_pid(filtered_pids, task->pid); } /** - * trace_pid_filter_add_remove - Add or remove a task from a pid_list + * trace_pid_filter_add_remove_task - Add or remove a task from a pid_list * @pid_list: The list to modify * @self: The current task for fork or NULL for exit * @task: The task to add or remove * * If adding a task, if @self is defined, the task is only added if @self * is also included in @pid_list. This happens on fork and tasks should * only be added when the parent is listed. If @self is NULL, then the * @task pid will be removed from the list, which would happen on exit @@ -920,17 +920,17 @@ void tracing_snapshot_instance(struct trace_array *tr) } local_irq_save(flags); update_max_tr(tr, current, smp_processor_id()); local_irq_restore(flags); } /** - * trace_snapshot - take a snapshot of the current buffer. + * tracing_snapshot - take a snapshot of the current buffer. * * This causes a swap between the snapshot buffer and the current live * tracing buffer. You can use this to take snapshots of the live * trace when some condition is triggered, but continue to trace. * * Note, make sure to allocate the snapshot with either * a tracing_snapshot_alloc(), or by doing it manually * with: echo 1 > /sys/kernel/debug/tracing/snapshot @@ -999,19 +999,19 @@ int tracing_alloc_snapshot(void) ret = tracing_alloc_snapshot_instance(tr); WARN_ON(ret < 0); return ret; } EXPORT_SYMBOL_GPL(tracing_alloc_snapshot); /** - * trace_snapshot_alloc - allocate and take a snapshot of the current buffer. + * tracing_snapshot_alloc - allocate and take a snapshot of the current buffer. * - * This is similar to trace_snapshot(), but it will allocate the + * This is similar to tracing_snapshot(), but it will allocate the * snapshot buffer if it isn't already allocated. Use this only * where it is safe to sleep, as the allocation may sleep. * * This causes a swap between the snapshot buffer and the current live * tracing buffer. You can use this to take snapshots of the live * trace when some condition is triggered, but continue to trace. */ void tracing_snapshot_alloc(void) @@ -1306,17 +1306,17 @@ static ssize_t trace_seq_to_buffer(struct trace_seq *s, void *buf, size_t cnt) } unsigned long __read_mostly tracing_thresh; #ifdef CONFIG_TRACER_MAX_TRACE /* * Copy the new maximum trace into the separate maximum-trace * structure. (this way the maximum trace is permanently saved, - * for later retrieval via /sys/kernel/debug/tracing/latency_trace) + * for later retrieval via /sys/kernel/tracing/tracing_max_latency) */ static void __update_max_tr(struct trace_array *tr, struct task_struct *tsk, int cpu) { struct trace_buffer *trace_buf = &tr->trace_buffer; struct trace_buffer *max_buf = &tr->max_buffer; struct trace_array_cpu *data = per_cpu_ptr(trace_buf->data, cpu); struct trace_array_cpu *max_data = per_cpu_ptr(max_buf->data, cpu);