| Message ID | 154295732797.2850.16990175697450002727.stgit@noble (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Assorted lustre patches - mostly from OpenSFS | expand |
On Fri, 23 Nov 2018, NeilBrown wrote: > From: Lai Siyao <lai.siyao@intel.com> > > DNE2 MDS should return -EXDEV upon remote rename, so that old > client can do rename with copy and delete, instead of fail > with -EREMOTE. Let me guess you were debugging the migration failures and fould this :-) I was doing the same thing. Reviewed-by: James Simmons <jsimmons@infradead.org> > Signed-off-by: Lai Siyao <lai.siyao@intel.com> > Change-Id: I68e8e99259065922f31bee5343be309380715674 > WC-bug-id: https://jira.whamcloud.com/browse/LU-6660 > Reviewed-on: http://review.whamcloud.com/15323 > Reviewed-by: Andreas Dilger <andreas.dilger@intel.com> > Reviewed-by: wangdi <di.wang@intel.com> > Reviewed-by: Fan Yong <fan.yong@intel.com> > Signed-off-by: NeilBrown <neilb@suse.com> > --- > drivers/staging/lustre/lustre/lmv/lmv_obd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/lustre/lustre/lmv/lmv_obd.c b/drivers/staging/lustre/lustre/lmv/lmv_obd.c > index 32bb9fca88c9..7e4ffeb15a63 100644 > --- a/drivers/staging/lustre/lustre/lmv/lmv_obd.c > +++ b/drivers/staging/lustre/lustre/lmv/lmv_obd.c > @@ -1945,7 +1945,7 @@ static int lmv_rename(struct obd_export *exp, struct md_op_data *op_data, > } > > rc = md_rename(target_exp, op_data, old, oldlen, new, newlen, request); > - if (rc && rc != -EREMOTE) > + if (rc && rc != -EXDEV) > return rc; > > body = req_capsule_server_get(&(*request)->rq_pill, &RMF_MDT_BODY); > > >
On Mon, Nov 26 2018, James Simmons wrote: > On Fri, 23 Nov 2018, NeilBrown wrote: > >> From: Lai Siyao <lai.siyao@intel.com> >> >> DNE2 MDS should return -EXDEV upon remote rename, so that old >> client can do rename with copy and delete, instead of fail >> with -EREMOTE. > > Let me guess you were debugging the migration failures and fould this :-) > I was doing the same thing. Nope - I was just looking though all the missing patches to see if anything was relevant. :-) Thanks for all the "Reviewed-by"s ! NeilBrown > > Reviewed-by: James Simmons <jsimmons@infradead.org> > >> Signed-off-by: Lai Siyao <lai.siyao@intel.com> >> Change-Id: I68e8e99259065922f31bee5343be309380715674 >> WC-bug-id: https://jira.whamcloud.com/browse/LU-6660 >> Reviewed-on: http://review.whamcloud.com/15323 >> Reviewed-by: Andreas Dilger <andreas.dilger@intel.com> >> Reviewed-by: wangdi <di.wang@intel.com> >> Reviewed-by: Fan Yong <fan.yong@intel.com> >> Signed-off-by: NeilBrown <neilb@suse.com> >> --- >> drivers/staging/lustre/lustre/lmv/lmv_obd.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/staging/lustre/lustre/lmv/lmv_obd.c b/drivers/staging/lustre/lustre/lmv/lmv_obd.c >> index 32bb9fca88c9..7e4ffeb15a63 100644 >> --- a/drivers/staging/lustre/lustre/lmv/lmv_obd.c >> +++ b/drivers/staging/lustre/lustre/lmv/lmv_obd.c >> @@ -1945,7 +1945,7 @@ static int lmv_rename(struct obd_export *exp, struct md_op_data *op_data, >> } >> >> rc = md_rename(target_exp, op_data, old, oldlen, new, newlen, request); >> - if (rc && rc != -EREMOTE) >> + if (rc && rc != -EXDEV) >> return rc; >> >> body = req_capsule_server_get(&(*request)->rq_pill, &RMF_MDT_BODY); >> >> >>
diff --git a/drivers/staging/lustre/lustre/lmv/lmv_obd.c b/drivers/staging/lustre/lustre/lmv/lmv_obd.c index 32bb9fca88c9..7e4ffeb15a63 100644 --- a/drivers/staging/lustre/lustre/lmv/lmv_obd.c +++ b/drivers/staging/lustre/lustre/lmv/lmv_obd.c @@ -1945,7 +1945,7 @@ static int lmv_rename(struct obd_export *exp, struct md_op_data *op_data, } rc = md_rename(target_exp, op_data, old, oldlen, new, newlen, request); - if (rc && rc != -EREMOTE) + if (rc && rc != -EXDEV) return rc; body = req_capsule_server_get(&(*request)->rq_pill, &RMF_MDT_BODY);