From patchwork Thu Feb 27 21:15:12 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Simmons X-Patchwork-Id: 11410597 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4F95E17E0 for ; Thu, 27 Feb 2020 21:42:04 +0000 (UTC) Received: from pdx1-mailman02.dreamhost.com (pdx1-mailman02.dreamhost.com [64.90.62.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3747824690 for ; Thu, 27 Feb 2020 21:42:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3747824690 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lustre-devel-bounces@lists.lustre.org Received: from pdx1-mailman02.dreamhost.com (localhost [IPv6:::1]) by pdx1-mailman02.dreamhost.com (Postfix) with ESMTP id 6DFD5349295; Thu, 27 Feb 2020 13:34:07 -0800 (PST) X-Original-To: lustre-devel@lists.lustre.org Delivered-To: lustre-devel-lustre.org@pdx1-mailman02.dreamhost.com Received: from smtp3.ccs.ornl.gov (smtp3.ccs.ornl.gov [160.91.203.39]) by pdx1-mailman02.dreamhost.com (Postfix) with ESMTP id B94A621F190 for ; Thu, 27 Feb 2020 13:20:36 -0800 (PST) Received: from star.ccs.ornl.gov (star.ccs.ornl.gov [160.91.202.134]) by smtp3.ccs.ornl.gov (Postfix) with ESMTP id 7FD748F34; Thu, 27 Feb 2020 16:18:18 -0500 (EST) Received: by star.ccs.ornl.gov (Postfix, from userid 2004) id 7E54F46D; Thu, 27 Feb 2020 16:18:18 -0500 (EST) From: James Simmons To: Andreas Dilger , Oleg Drokin , NeilBrown Date: Thu, 27 Feb 2020 16:15:12 -0500 Message-Id: <1582838290-17243-445-git-send-email-jsimmons@infradead.org> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1582838290-17243-1-git-send-email-jsimmons@infradead.org> References: <1582838290-17243-1-git-send-email-jsimmons@infradead.org> Subject: [lustre-devel] [PATCH 444/622] lnet: Fix style issues for module.c conctl.c X-BeenThere: lustre-devel@lists.lustre.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "For discussing Lustre software development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lustre Development List MIME-Version: 1.0 Errors-To: lustre-devel-bounces@lists.lustre.org Sender: "lustre-devel" From: Shaun Tancheff This patch fixes issues reported by checkpatch for the file selftest/module.c and selftest/conctl.c. Linux 5.3 enforces the use of 'fallthrough' which is also suggested by checkpatch Cray-bug-id: LUS-7690 WC-bug-id: https://jira.whamcloud.com/browse/LU-12635 Lustre-commit: ebff8aba3392 ("LU-12635 lnet: Fix style issues for module.c conctl.c") Signed-off-by: Shaun Tancheff Reviewed-on: https://review.whamcloud.com/35802 Reviewed-by: Petros Koutoupis Reviewed-by: Neil Brown Reviewed-by: Arshad Hussain Reviewed-by: Oleg Drokin Signed-off-by: James Simmons --- net/lnet/selftest/conctl.c | 4 ++-- net/lnet/selftest/module.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/net/lnet/selftest/conctl.c b/net/lnet/selftest/conctl.c index 906d82d..ed9eab9 100644 --- a/net/lnet/selftest/conctl.c +++ b/net/lnet/selftest/conctl.c @@ -121,7 +121,6 @@ return -EINVAL; if (args->lstio_dbg_namep) { - if (copy_from_user(name, args->lstio_dbg_namep, args->lstio_dbg_nmlen)) return -EFAULT; @@ -727,7 +726,8 @@ static int lst_test_add_ioctl(struct lstio_test_args *args) goto out; } - memset(&console_session.ses_trans_stat, 0, sizeof(struct lstcon_trans_stat)); + memset(&console_session.ses_trans_stat, + 0, sizeof(struct lstcon_trans_stat)); switch (opc) { case LSTIO_SESSION_NEW: diff --git a/net/lnet/selftest/module.c b/net/lnet/selftest/module.c index 9ba6532..2de2b59 100644 --- a/net/lnet/selftest/module.c +++ b/net/lnet/selftest/module.c @@ -105,7 +105,7 @@ enum { nscheds = cfs_cpt_number(lnet_cpt_table()); lst_test_wq = kvmalloc_array(nscheds, sizeof(lst_test_wq[0]), - GFP_KERNEL | __GFP_ZERO); + GFP_KERNEL | __GFP_ZERO); if (!lst_test_wq) { rc = -ENOMEM; goto error;