From patchwork Thu Aug 4 01:37:46 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Simmons X-Patchwork-Id: 12935972 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from pdx1-mailman-customer002.dreamhost.com (listserver-buz.dreamhost.com [69.163.136.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0D72DC19F2D for ; Thu, 4 Aug 2022 01:38:29 +0000 (UTC) Received: from pdx1-mailman-customer002.dreamhost.com (localhost [127.0.0.1]) by pdx1-mailman-customer002.dreamhost.com (Postfix) with ESMTP id 4LyrwN2fQqz21H4; Wed, 3 Aug 2022 18:38:28 -0700 (PDT) Received: from smtp4.ccs.ornl.gov (smtp4.ccs.ornl.gov [160.91.203.40]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pdx1-mailman-customer002.dreamhost.com (Postfix) with ESMTPS id 4LyrwL16CVz1y73 for ; Wed, 3 Aug 2022 18:38:26 -0700 (PDT) Received: from star.ccs.ornl.gov (star.ccs.ornl.gov [160.91.202.134]) by smtp4.ccs.ornl.gov (Postfix) with ESMTP id A35F7100AFEF; Wed, 3 Aug 2022 21:38:23 -0400 (EDT) Received: by star.ccs.ornl.gov (Postfix, from userid 2004) id 9D60582CCE; Wed, 3 Aug 2022 21:38:23 -0400 (EDT) From: James Simmons To: Andreas Dilger , Oleg Drokin , NeilBrown Date: Wed, 3 Aug 2022 21:37:46 -0400 Message-Id: <1659577097-19253-2-git-send-email-jsimmons@infradead.org> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1659577097-19253-1-git-send-email-jsimmons@infradead.org> References: <1659577097-19253-1-git-send-email-jsimmons@infradead.org> Subject: [lustre-devel] [PATCH 01/32] lustre: mdc: Remove entry from list before freeing X-BeenThere: lustre-devel@lists.lustre.org X-Mailman-Version: 2.1.39 Precedence: list List-Id: "For discussing Lustre software development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lustre Development List MIME-Version: 1.0 Errors-To: lustre-devel-bounces@lists.lustre.org Sender: "lustre-devel" From: Oleg Drokin mdc_changelog_cdev_init forgot to remove entries from list if chardev allocation failed Fixes: dcedf3009a71 ("lustre: changelog: support large number of MDT") WC-bug-id: https://jira.whamcloud.com/browse/LU-15901 Lustre-commit: 441ec2296a0938dd3 ("LU-15901 mdc: Remove entry from list before freeing") Signed-off-by: Oleg Drokin Reviewed-on: https://review.whamcloud.com/47480 Reviewed-by: Andreas Dilger Reviewed-by: Lai Siyao Reviewed-by: James Simmons Signed-off-by: James Simmons --- fs/lustre/mdc/mdc_changelog.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/lustre/mdc/mdc_changelog.c b/fs/lustre/mdc/mdc_changelog.c index d366720..36d7fdd 100644 --- a/fs/lustre/mdc/mdc_changelog.c +++ b/fs/lustre/mdc/mdc_changelog.c @@ -837,7 +837,7 @@ int mdc_changelog_cdev_init(struct obd_device *obd) rc = chlg_minor_alloc(&minor); if (rc) - goto out_unlock; + goto out_listrm; device_initialize(&entry->ced_device); entry->ced_device.devt = MKDEV(MAJOR(mdc_changelog_dev), minor); @@ -866,6 +866,7 @@ int mdc_changelog_cdev_init(struct obd_device *obd) out_minor: chlg_minor_free(minor); +out_listrm: list_del_init(&obd->u.cli.cl_chg_dev_linkage); list_del(&entry->ced_link);