| Message ID | 20220623005948.291792-1-kishen.maloor@intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | mptcp: support MP_PRIO signals with userspace PMs | expand |
On Wed, 22 Jun 2022, Kishen Maloor wrote: > This patch series updates MPTCP_PM_CMD_SET_FLAGS to allow userspace PMs > to issue MP_PRIO signals for a specified address ID over a chosen > MPTCP connection. It also adds self testing support for this change. > > v2: > -userspace_pm.sh: added a sleep after issuing the MP_PRIO signal. Thanks Kishen. v2 looks good to me: Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com> > > Kishen Maloor (2): > mptcp: netlink: issue MP_PRIO signals from userspace PMs > selftests: mptcp: userspace PM support for MP_PRIO signals > > net/mptcp/pm_netlink.c | 23 +++++++++---- > net/mptcp/pm_userspace.c | 30 +++++++++++++++++ > net/mptcp/protocol.h | 6 +++- > tools/testing/selftests/net/mptcp/pm_nl_ctl.c | 19 +++++++++-- > .../selftests/net/mptcp/userspace_pm.sh | 32 +++++++++++++++++++ > 5 files changed, 101 insertions(+), 9 deletions(-) > > > base-commit: 68fec8b7f640037e4bf224ca4e924574098f5911 > -- > 2.31.1 > > -- Mat Martineau Intel
On Thu, 23 Jun 2022, Mat Martineau wrote: > On Wed, 22 Jun 2022, Kishen Maloor wrote: > >> This patch series updates MPTCP_PM_CMD_SET_FLAGS to allow userspace PMs >> to issue MP_PRIO signals for a specified address ID over a chosen >> MPTCP connection. It also adds self testing support for this change. >> >> v2: >> -userspace_pm.sh: added a sleep after issuing the MP_PRIO signal. > > Thanks Kishen. v2 looks good to me: > > Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com> > I spoke too soon. I was looking at the multipath-tcp.org API for changing the backup flag with Ossama, and that netlink command (MPTCP_CMD_SUB_PRIORITY) uses the local and remote addresses and port numbers rather than the endpoint IDs. This is so the priority can be changed for an individual subflow. The API parameters I asked for in issue 286 would only allow priority to be changed for all subflows using a specific local endpoint, which is not specific enough. I'll update https://github.com/multipath-tcp/mptcp_net-next/issues/286 to request a change to the MPTCP_PM_CMD_SET_FLAGS parameters. >> >> Kishen Maloor (2): >> mptcp: netlink: issue MP_PRIO signals from userspace PMs >> selftests: mptcp: userspace PM support for MP_PRIO signals >> >> net/mptcp/pm_netlink.c | 23 +++++++++---- >> net/mptcp/pm_userspace.c | 30 +++++++++++++++++ >> net/mptcp/protocol.h | 6 +++- >> tools/testing/selftests/net/mptcp/pm_nl_ctl.c | 19 +++++++++-- >> .../selftests/net/mptcp/userspace_pm.sh | 32 +++++++++++++++++++ >> 5 files changed, 101 insertions(+), 9 deletions(-) >> >> >> base-commit: 68fec8b7f640037e4bf224ca4e924574098f5911 >> -- >> 2.31.1 >> >> -- Mat Martineau Intel