| Message ID | 20240430-sysctl_scheduler-v1-0-8187148850df@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | mptcp: fix net.mptcp.scheduler behavior | expand |
Hi Gregory, Thank you for your modifications, that's great! Our CI did some validations and here is its report: - KVM Validation: normal: Success! ✅ - KVM Validation: debug: Unstable: 1 failed test(s): selftest_mptcp_join
Hi Gregory, On 30/04/2024 14:06, Gregory Detal wrote: > The sysctl is accepting any input. This patchset ensures only > existing scheduler can be set. > > Moreover, this adds an helper sysctl to list the available scheduler > similarly to tcp_available_congestion_control. > > The first patch of the series is a fix for mptcp-net. Thank you for this fix, it makes sense! And thanks for the new sysctl entry, it will be useful! Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org> @Mat / @Geliang: because I did a review "internally" with Gregory, do not hesitate to have a quick look to have an external point of view :) Cheers, Matt
Hi Gregory, On 30/04/2024 14:59, MPTCP CI wrote: > Hi Gregory, > > Thank you for your modifications, that's great! > > Our CI did some validations and here is its report: > > - KVM Validation: normal: Success! ✅ > - KVM Validation: debug: Unstable: 1 failed test(s): selftest_mptcp_join
Hi Gregory, On Tue, Apr 30, 2024 at 04:00:17PM +0200, Matthieu Baerts wrote: > Hi Gregory, > > On 30/04/2024 14:06, Gregory Detal wrote: > > The sysctl is accepting any input. This patchset ensures only > > existing scheduler can be set. > > > > Moreover, this adds an helper sysctl to list the available scheduler > > similarly to tcp_available_congestion_control. > > > > The first patch of the series is a fix for mptcp-net. > > Thank you for this fix, it makes sense! And thanks for the new sysctl > entry, it will be useful! > > Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org> Thanks for these patches, all tests passed. Tested-by: Geliang Tang <geliang@kernel.org> -Geliang > > @Mat / @Geliang: because I did a review "internally" with Gregory, do > not hesitate to have a quick look to have an external point of view :) > > Cheers, > Matt > -- > Sponsored by the NGI0 Core fund. >
On Tue, 30 Apr 2024, Gregory Detal wrote: > The sysctl is accepting any input. This patchset ensures only > existing scheduler can be set. > > Moreover, this adds an helper sysctl to list the available scheduler > similarly to tcp_available_congestion_control. > > The first patch of the series is a fix for mptcp-net. > > Signed-off-by: Gregory Detal <gregory.detal@gmail.com> Series looks good to me as well (and Matthieu can remove that newline if he'd like). Thanks for the patches! Reviewed-by: Mat Martineau <martineau@kernel.org> > --- > Gregory Detal (2): > mptcp: only allow set existing scheduler for net.mptcp.scheduler > mptcp: add net.mptcp.available_schedulers > > include/net/mptcp.h | 3 +++ > net/mptcp/ctrl.c | 67 ++++++++++++++++++++++++++++++++++++++++++++++++++-- > net/mptcp/protocol.h | 1 + > net/mptcp/sched.c | 22 +++++++++++++++++ > 4 files changed, 91 insertions(+), 2 deletions(-) > --- > base-commit: dd741144c1d1e3bd1fed5eb0ded1934c9230b4ef > change-id: 20240430-sysctl_scheduler-13367d5bf81a > > Best regards, > -- > Gregory Detal <gregory.detal@gmail.com> > > >
Hi Gregory, Geliang, Mat, On 30/04/2024 14:06, Gregory Detal wrote: > The sysctl is accepting any input. This patchset ensures only > existing scheduler can be set. > > Moreover, this adds an helper sysctl to list the available scheduler > similarly to tcp_available_congestion_control. > > The first patch of the series is a fix for mptcp-net. Thank you for the patches, the tests, and the review: New patches for t/upstream-net and t/upstream: - bc3eac499491: mptcp: only allow set existing scheduler for net.mptcp.scheduler - Results: 9df9126ccb3d..193bf8fbc31b (export-net) - Results: c1f52bb3cea5..e83515296801 (export) New patches for t/upstream: - 660afb67d62f: mptcp: add net.mptcp.available_schedulers - Results: e83515296801..022e39266b3c (export) Tests are now in progress: - export: https://github.com/multipath-tcp/mptcp_net-next/commit/56030f9d3812071365435354c0eb5ffb3504e58a/checks - export-net: https://github.com/multipath-tcp/mptcp_net-next/commit/a6e18d675691b704ed8e61862efa61464ffbeeb7/checks Cheers, Matt
The sysctl is accepting any input. This patchset ensures only existing scheduler can be set. Moreover, this adds an helper sysctl to list the available scheduler similarly to tcp_available_congestion_control. The first patch of the series is a fix for mptcp-net. Signed-off-by: Gregory Detal <gregory.detal@gmail.com> --- Gregory Detal (2): mptcp: only allow set existing scheduler for net.mptcp.scheduler mptcp: add net.mptcp.available_schedulers include/net/mptcp.h | 3 +++ net/mptcp/ctrl.c | 67 ++++++++++++++++++++++++++++++++++++++++++++++++++-- net/mptcp/protocol.h | 1 + net/mptcp/sched.c | 22 +++++++++++++++++ 4 files changed, 91 insertions(+), 2 deletions(-) --- base-commit: dd741144c1d1e3bd1fed5eb0ded1934c9230b4ef change-id: 20240430-sysctl_scheduler-13367d5bf81a Best regards,