[mptcp-net,0/3] selftests: mptcp: misc. small fixes

Message

Matthieu Baerts (NGI0) Sept. 10, 2024, 4:51 p.m. UTC

Here are some various fixes for the MPTCP selftests.

Patch 1 fixes a recently modified test to continue to work as expected
on older kernels. This is a fix for a recent fix that can be backported
up to v5.15.

Patch 2 and 3 include dependences when exporting or installing the
tests. Two fixes for v6.11-rc1.

Because the fixes are quite straightforward, I suggest to send these
patches soon after to Netdev, hopefully to be included before the final
v6.11.

Signed-off-by: Matthieu Baerts (NGI0) <[e-mail]>
---
Matthieu Baerts (NGI0) (3):
      selftests: mptcp: join: restrict fullmesh endp on 1st sf
      selftests: mptcp: include lib.sh file
      selftests: mptcp: include net_helper.sh file

 tools/testing/selftests/net/mptcp/Makefile      | 2 ++
 tools/testing/selftests/net/mptcp/mptcp_join.sh | 4 +++-
 2 files changed, 5 insertions(+), 1 deletion(-)
---
base-commit: 085cc64096c367f8c90237934304f82384d37e5d
change-id: 20240910-selftests-mptcp-fix-install-a9a4edad7d0c

Best regards,

Comments

MPTCP CI Sept. 10, 2024, 5:49 p.m. UTC | #1

Hi Matthieu,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal: Success! ✅
- KVM Validation: debug: Success! ✅
- KVM Validation: btf (only bpftest_all): Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/10797305656

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/fba3bf5d0fe7
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=888987


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-normal

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)

Matthieu Baerts (NGI0) Sept. 10, 2024, 7:06 p.m. UTC | #2

Hello,

On 10/09/2024 18:51, Matthieu Baerts (NGI0) wrote:
> Here are some various fixes for the MPTCP selftests.
> 
> Patch 1 fixes a recently modified test to continue to work as expected
> on older kernels. This is a fix for a recent fix that can be backported
> up to v5.15.
> 
> Patch 2 and 3 include dependences when exporting or installing the
> tests. Two fixes for v6.11-rc1.
> 
> Because the fixes are quite straightforward, I suggest to send these
> patches soon after to Netdev, hopefully to be included before the final
> v6.11.

Just applied in our tree:

New patches for t/upstream-net and t/upstream:
- db11527f3688: selftests: mptcp: join: restrict fullmesh endp on 1st sf
- 685e393ba885: selftests: mptcp: include lib.sh file
- 2c8af9766f26: selftests: mptcp: include net_helper.sh file
- Results: 1bde6ee4cd32..a6bb83c9a6f1 (export-net)
- Results: 085cc64096c3..b4ced873ec79 (export)

Tests are now in progress:

- export-net:
https://github.com/multipath-tcp/mptcp_net-next/commit/7c3c5b71ac72ab6539d1bd49156b9732688d7f6c/checks
- export:
https://github.com/multipath-tcp/mptcp_net-next/commit/242ed77d7ffdf2b73e373dd8fe3d8282eee6f9f4/checks

Cheers,
Matt