mbox series

[mptcp-net,0/2] mptcp: remove unneeded lock when listing scheds

Message ID 20241017-mptcp-sched-avail-lock-v1-0-028ef592c6f4@kernel.org (mailing list archive)
Headers show
Series mptcp: remove unneeded lock when listing scheds | expand

Message

Matthieu Baerts (NGI0) Oct. 17, 2024, 10:16 a.m. UTC
A fix suggested by Paolo, and a small addition in the selftests to
increase the code coverage. I guess they can both go to -net.

Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
---
Matthieu Baerts (NGI0) (2):
      mptcp: remove unneeded lock when listing scheds
      selftests: mptcp: list sysctl data

 net/mptcp/sched.c                                  | 2 --
 tools/testing/selftests/net/mptcp/mptcp_connect.sh | 9 +++++++++
 2 files changed, 9 insertions(+), 2 deletions(-)
---
base-commit: c60af6efcac3836a49c583f8a127560697d8c3a8
change-id: 20241017-mptcp-sched-avail-lock-a60714cb3218

Best regards,

Comments

MPTCP CI Oct. 17, 2024, 11:22 a.m. UTC | #1
Hi Matthieu,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal: Success! ✅
- KVM Validation: debug: Success! ✅
- KVM Validation: btf-normal (only bpftest_all): Success! ✅
- KVM Validation: btf-debug (only bpftest_all): Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/11383138502

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/8866d19ec4ef
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=900176


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-normal

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)
Matthieu Baerts (NGI0) Oct. 19, 2024, 11:53 a.m. UTC | #2
Hi Geliang,

On 17/10/2024 12:16, Matthieu Baerts (NGI0) wrote:
> A fix suggested by Paolo, and a small addition in the selftests to
> increase the code coverage. I guess they can both go to -net.

Thank you for your review on patch 1/2, I just applied the series in our
tree:

New patches for t/upstream-net and t/upstream:
- 7c2d2c795bd4: mptcp: remove unneeded lock when listing scheds
- 5f07b4f41bdd: selftests: mptcp: list sysctl data
- Results: e7969542d0a3..30a6ded06481 (export-net)
- Results: dc99b2bc6131..54b01fd36ac6 (export)

Tests are now in progress:

- export-net:
https://github.com/multipath-tcp/mptcp_net-next/commit/136da0312931deb877b993a5d5a0fa6861e5da54/checks
- export:
https://github.com/multipath-tcp/mptcp_net-next/commit/8d5658f1131d99357c5533d88541880bd97d0539/checks


Cheers,
Matt