| Message ID | 20241230-genl_req_attr_check-v6-0-3ec9103559e7@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | mptcp: use GENL_REQ_ATTR_CHECK in userspace pm | expand |
Hi Matthieu, Thank you for your modifications, that's great! Our CI did some validations and here is its report: - KVM Validation: normal: Success! ✅ - KVM Validation: debug: Success! ✅ - KVM Validation: btf-normal (only bpftest_all): Success! ✅ - KVM Validation: btf-debug (only bpftest_all): Unstable: 1 failed test(s): bpftest_test_progs-no_alu32_mptcp
Hi Matt, Thanks for this new version. On Mon, 2024-12-30 at 14:24 +0100, Matthieu Baerts (NGI0) wrote: > This is a newer version of the series started by Geliang, now making > them more uniform on how the NL errors are set, and giving more hints > to > the userspace about what's wrong. This series is useful, but it conflicts with "BPF path manager" series under review, especially with set_flags() interface. So I also added the patches to update set_flags interface into v7. > > Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org> > --- > Geliang Tang (1): > mptcp: pm: userspace: use GENL_REQ_ATTR_CHECK > > Matthieu Baerts (NGI0) (6): > mptcp: pm: use NL_SET_ERR_MSG_ATTR when possible > mptcp: pm: more precise error messages > mptcp: pm: improve error messages > mptcp: pm: userspace: flags: clearer msg if no remote addr > mptcp: pm: remove duplicated error messages > mptcp: pm: mark missing address attributes > > net/mptcp/pm_netlink.c | 50 +++++++++++----- > net/mptcp/pm_userspace.c | 144 ++++++++++++++++++++++++++++--------- > ---------- > 2 files changed, 121 insertions(+), 73 deletions(-) > --- > base-commit: f770d70d123db1907d419f715117245d7060816b > change-id: 20241228-genl_req_attr_check-2accaa49f84f > > Best regards,
Hi Geliang, On 06/01/2025 09:24, Geliang Tang wrote: > Hi Matt, > > Thanks for this new version. > > On Mon, 2024-12-30 at 14:24 +0100, Matthieu Baerts (NGI0) wrote: >> This is a newer version of the series started by Geliang, now making >> them more uniform on how the NL errors are set, and giving more hints >> to >> the userspace about what's wrong. > > This series is useful, but it conflicts with "BPF path manager" series > under review, especially with set_flags() interface. So I also added > the patches to update set_flags interface into v7. Yes, sorry about that, I noticed that after having sent this series. Cheers, Matt
This is a newer version of the series started by Geliang, now making them more uniform on how the NL errors are set, and giving more hints to the userspace about what's wrong. Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org> --- Geliang Tang (1): mptcp: pm: userspace: use GENL_REQ_ATTR_CHECK Matthieu Baerts (NGI0) (6): mptcp: pm: use NL_SET_ERR_MSG_ATTR when possible mptcp: pm: more precise error messages mptcp: pm: improve error messages mptcp: pm: userspace: flags: clearer msg if no remote addr mptcp: pm: remove duplicated error messages mptcp: pm: mark missing address attributes net/mptcp/pm_netlink.c | 50 +++++++++++----- net/mptcp/pm_userspace.c | 144 ++++++++++++++++++++++++++++------------------- 2 files changed, 121 insertions(+), 73 deletions(-) --- base-commit: f770d70d123db1907d419f715117245d7060816b change-id: 20241228-genl_req_attr_check-2accaa49f84f Best regards,