| Message ID | 20250207-net-next-mptcp-pm-misc-cleanup-2-v3-0-71753ed957de@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | mptcp: pm: misc cleanups, part 2 | expand |
Hello: This series was applied to netdev/net-next.git (main) by Paolo Abeni <pabeni@redhat.com>: On Fri, 07 Feb 2025 14:59:18 +0100 you wrote: > These cleanups lead the way to the unification of the path-manager > interfaces, and allow future extensions. The following patches are not > all linked to each others, but are all related to the path-managers. > > - Patch 1: drop unneeded parameter in a function helper. > > - Patch 2: clearer NL error message when an NL attribute is missing. > > [...] Here is the summary with links: - [net-next,v3,01/15] mptcp: pm: drop info of userspace_pm_remove_id_zero_address https://git.kernel.org/netdev/net-next/c/a9d71b5de76c - [net-next,v3,02/15] mptcp: pm: userspace: flags: clearer msg if no remote addr https://git.kernel.org/netdev/net-next/c/58b21309f97b - [net-next,v3,03/15] mptcp: pm: more precise error messages https://git.kernel.org/netdev/net-next/c/891a87f7a76c - [net-next,v3,04/15] mptcp: pm: improve error messages https://git.kernel.org/netdev/net-next/c/b2bdec19beec - [net-next,v3,05/15] mptcp: pm: userspace: use GENL_REQ_ATTR_CHECK https://git.kernel.org/netdev/net-next/c/07bfabf8407b - [net-next,v3,06/15] mptcp: pm: remove duplicated error messages https://git.kernel.org/netdev/net-next/c/60097f03fc7a - [net-next,v3,07/15] mptcp: pm: mark missing address attributes https://git.kernel.org/netdev/net-next/c/8cdc56f99e6c - [net-next,v3,08/15] mptcp: pm: use NL_SET_ERR_MSG_ATTR when possible https://git.kernel.org/netdev/net-next/c/a25a8b10491b - [net-next,v3,09/15] mptcp: pm: make three pm wrappers static https://git.kernel.org/netdev/net-next/c/7aeab89b090f - [net-next,v3,10/15] mptcp: pm: drop skb parameter of get_addr https://git.kernel.org/netdev/net-next/c/67dcf6592544 - [net-next,v3,11/15] mptcp: pm: add id parameter for get_addr https://git.kernel.org/netdev/net-next/c/d47b80758f4c - [net-next,v3,12/15] mptcp: pm: reuse sending nlmsg code in get_addr https://git.kernel.org/netdev/net-next/c/8556f4aecc9a - [net-next,v3,13/15] mptcp: pm: drop skb parameter of set_flags https://git.kernel.org/netdev/net-next/c/2c8971c04f74 - [net-next,v3,14/15] mptcp: pm: change rem type of set_flags https://git.kernel.org/netdev/net-next/c/ab5723599cfd - [net-next,v3,15/15] mptcp: pm: add local parameter for set_flags https://git.kernel.org/netdev/net-next/c/c7f25f7987c0 You are awesome, thank you!
These cleanups lead the way to the unification of the path-manager interfaces, and allow future extensions. The following patches are not all linked to each others, but are all related to the path-managers. - Patch 1: drop unneeded parameter in a function helper. - Patch 2: clearer NL error message when an NL attribute is missing. - Patch 3: more precise NL messages by avoiding 'this or that is NOK'. - Patch 4: improve too vague or missing NL err messages. - Patch 5: use GENL_REQ_ATTR_CHECK to look for mandatory NL attributes. - Patch 6: avoid overriding the error message. - Patch 7: check all mandatory NL attributes with GENL_REQ_ATTR_CHECK. - Patch 8: use NL_SET_ERR_MSG_ATTR instead of GENL_SET_ERR_MSG - Patch 9: move doit callbacks used for both PM to pm.c. - Patch 10: drop another unneeded parameter in a function helper. - Patch 11: share the ID parsing code for the 'get_addr' callback. - Patch 12: share sending NL code for the 'get_addr' callback. - Patch 13: drop yet another unneeded parameter in a function helper. - Patch 14: pick the usual structure type for the remote address. - Patch 15: share the local addr parsing code for the 'set_flags' cb. The behaviour when there are no errors should then not be modified. Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org> --- Changes in v3: - Patch 11: a variable was no longer assigned in pm_userspace.c, but still used in this patch (and no longer in the next one). (Geliang) - Rebased on top of the latest net-next. - Link to v2: https://lore.kernel.org/r/20250117-net-next-mptcp-pm-misc-cleanup-2-v2-0-61d4fe0586e8@kernel.org Changes in v2: - Patch 11: a variable was no longer assigned in pm_netlink.c, but still used in this patch (and no longer in the next one). (Simon) - Link to v1: https://lore.kernel.org/r/20250116-net-next-mptcp-pm-misc-cleanup-2-v1-0-c0b43f18fe06@kernel.org --- Geliang Tang (9): mptcp: pm: drop info of userspace_pm_remove_id_zero_address mptcp: pm: userspace: use GENL_REQ_ATTR_CHECK mptcp: pm: make three pm wrappers static mptcp: pm: drop skb parameter of get_addr mptcp: pm: add id parameter for get_addr mptcp: pm: reuse sending nlmsg code in get_addr mptcp: pm: drop skb parameter of set_flags mptcp: pm: change rem type of set_flags mptcp: pm: add local parameter for set_flags Matthieu Baerts (NGI0) (6): mptcp: pm: userspace: flags: clearer msg if no remote addr mptcp: pm: more precise error messages mptcp: pm: improve error messages mptcp: pm: remove duplicated error messages mptcp: pm: mark missing address attributes mptcp: pm: use NL_SET_ERR_MSG_ATTR when possible net/mptcp/pm.c | 86 +++++++++++++++++-- net/mptcp/pm_netlink.c | 129 ++++++++++------------------- net/mptcp/pm_userspace.c | 209 +++++++++++++++++++++-------------------------- net/mptcp/protocol.h | 14 ++-- 4 files changed, 225 insertions(+), 213 deletions(-) --- base-commit: 26db4dbb747813b5946aff31485873f071a10332 change-id: 20250116-net-next-mptcp-pm-misc-cleanup-2-b0f50eff8084 Best regards,