| Message ID | 20250217-mptcp-dss-drop-mpj-v1-0-d671d6b9a153@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | mptcp: reset when MPTCP opts are dropped after MPJ | expand |
Hi Matthieu,
Thank you for your modifications, that's great!
Our CI did some validations and here is its report:
- KVM Validation: normal: Critical: Global Timeout ❌
- KVM Validation: debug: Success! ✅
- KVM Validation: btf-normal (only bpftest_all): Success! ✅
- KVM Validation: btf-debug (only bpftest_all): Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/13366428077
Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/4b6ff0b2c9f9
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=934579
If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:
$ cd [kernel source code]
$ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
--pull always mptcp/mptcp-upstream-virtme-docker:latest \
auto-normal
For more details:
https://github.com/multipath-tcp/mptcp-upstream-virtme-docker
Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)
Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)
Hi Matthieu,
Thank you for your modifications, that's great!
Our CI did some validations and here is its report:
- KVM Validation: normal: Success! ✅
- KVM Validation: debug: Success! ✅
- KVM Validation: btf-normal (only bpftest_all): Success! ✅
- KVM Validation: btf-debug (only bpftest_all): Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/13366428077
Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/4b6ff0b2c9f9
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=934579
If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:
$ cd [kernel source code]
$ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
--pull always mptcp/mptcp-upstream-virtme-docker:latest \
auto-normal
For more details:
https://github.com/multipath-tcp/mptcp-upstream-virtme-docker
Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)
Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)
This series fixes the issue #544 where a middlebox drops MPTCP options after a 3WHS on the additional subflow. Two additional patches have been added: - Patch 2: for an issue seen when debugging the previous one: there should be a fallback after the reception of an infinite mapping, only if allowed. - Patch 3: to avoid the issues fixed by the two patches above, a safety check is added when asking to do a fallback if it is not possible to do so. A warning will be emitted in this case. Note that two new packetdrill tests have been added in a PR to cover this case: https://github.com/multipath-tcp/packetdrill/pull/160 Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org> --- Matthieu Baerts (NGI0) (3): mptcp: reset when MPTCP opts are dropped after join mptcp: only fallback due to inf mapping if allowed mptcp: safety check before fallback net/mptcp/protocol.h | 2 ++ net/mptcp/subflow.c | 23 ++++++++++++++--------- 2 files changed, 16 insertions(+), 9 deletions(-) --- base-commit: 3a7786db65e8f361a8fc8abcd3cfbe17411b8b7f change-id: 20250205-mptcp-dss-drop-mpj-ec227f4ed942 Best regards,