[mptcp-next,v4,0/6] run sched tests in a dedicated ns

Message

Geliang Tang May 17, 2023, 10:29 p.m. UTC

v4:
 - patch #1 could be merged before "mptcp: refactor push_pending logic"
   as a single fix.
 - patch #2 should be merged between "selftests/bpf: Add mptcp sched
   structs" and "selftests/bpf: Add bpf_first scheduler".

v3:
 - add two helpers.
 - drop sched_cleanup().

Geliang Tang (6):
  selftests/bpf: use random netns name for mptcp
  selftests/bpf: add two mptcp netns helpers
  Squash to "selftests/bpf: Add bpf_first test"
  Squash to "selftests/bpf: Add bpf_bkup test"
  Squash to "selftests/bpf: Add bpf_rr test"
  Squash to "selftests/bpf: Add bpf_red test"

 .../testing/selftests/bpf/prog_tests/mptcp.c  | 109 +++++++++++-------
 1 file changed, 68 insertions(+), 41 deletions(-)

Comments

Matthieu Baerts May 19, 2023, 9:36 a.m. UTC | #1

Hi Geliang,

On 18/05/2023 00:29, Geliang Tang wrote:
> v4:
>  - patch #1 could be merged before "mptcp: refactor push_pending logic"
>    as a single fix.
>  - patch #2 should be merged between "selftests/bpf: Add mptcp sched
>    structs" and "selftests/bpf: Add bpf_first scheduler".

Thank you for the new version and for the explanations!

I suggest to apply the first patch also between "selftests/bpf: Add
mptcp sched structs" and "selftests/bpf: Add bpf_first scheduler" as it
seems not needed before (see my comment on this patch).

Reviewed-by: Matthieu Baerts <[e-mail]>

Cheers,
Matt

Geliang Tang May 19, 2023, 9:58 a.m. UTC | #2

Matthieu Baerts <[e-mail]> 于2023年5月19日周五 17:36写道：
>
> Hi Geliang,
>
> On 18/05/2023 00:29, Geliang Tang wrote:
> > v4:
> >  - patch #1 could be merged before "mptcp: refactor push_pending logic"
> >    as a single fix.
> >  - patch #2 should be merged between "selftests/bpf: Add mptcp sched
> >    structs" and "selftests/bpf: Add bpf_first scheduler".
>
> Thank you for the new version and for the explanations!
>
> I suggest to apply the first patch also between "selftests/bpf: Add
> mptcp sched structs" and "selftests/bpf: Add bpf_first scheduler" as it
> seems not needed before (see my comment on this patch).

I agree. Please update the commit logs for me when merging them.

Thanks,
-Geliang

>
> Reviewed-by: Matthieu Baerts <[e-mail]>
>
> Cheers,
> Matt
> --
> Tessares | Belgium | Hybrid Access Solutions
> www.tessares.net
>

Matthieu Baerts May 19, 2023, 12:03 p.m. UTC | #3

Hi Geliang,

On 19/05/2023 11:58, Geliang Tang wrote:
> Matthieu Baerts <[e-mail]> 于2023年5月19日周五 17:36写道：
>>
>> Hi Geliang,
>>
>> On 18/05/2023 00:29, Geliang Tang wrote:
>>> v4:
>>>  - patch #1 could be merged before "mptcp: refactor push_pending logic"
>>>    as a single fix.
>>>  - patch #2 should be merged between "selftests/bpf: Add mptcp sched
>>>    structs" and "selftests/bpf: Add bpf_first scheduler".
>>
>> Thank you for the new version and for the explanations!
>>
>> I suggest to apply the first patch also between "selftests/bpf: Add
>> mptcp sched structs" and "selftests/bpf: Add bpf_first scheduler" as it
>> seems not needed before (see my comment on this patch).
> 
> I agree. Please update the commit logs for me when merging them.

Great, just did, hopefully as expected.

New patches for t/upstream:
- 022ddca0dd31: selftests/bpf: use random netns name for mptcp
- fa066ce14aa8: selftests/bpf: add two mptcp netns helpers
- 90d56a205185: "squashed" patch 3/6 in "selftests/bpf: Add bpf_first test"
- e17099987f21: "squashed" patch 4/6 in "selftests/bpf: Add bpf_bkup test"
- 8c10fe1b6365: "squashed" patch 5/6 in "selftests/bpf: Add bpf_rr test"
- 4101020d41c3: "squashed" patch 6/6 in "selftests/bpf: Add bpf_red test"
- Results: c20d0380b999..577d6a7db2fb (export)

Tests are now in progress:

https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20230519T120144

Cheers,
Matt