[v2,mptcp-net,0/2] mptcp: fix another deadlock issue

Message

Paolo Abeni Feb. 21, 2024, 3:32 p.m. UTC

Eric reported and diagnosed another possible deadlock problem with
the MPTCP diag code. The first patch address the issue, and the second
adds self-test coverage for the relevant codepath, to get lockdep help
to catch future similar issues.

following-up with the netdev fiasco, sending on mptcp only

v1 -> v2:
 - fix (avoid) feature detection in patch 2/2 (Matttbe)

Paolo Abeni (2):
  mptcp: fix possible deadlock in subflow diag
  selftests: mptcp: explicitly trigger the listener diag code-path

 net/mptcp/diag.c                          |  3 +++
 tools/testing/selftests/net/mptcp/diag.sh | 24 +++++++++++++++++++++++
 2 files changed, 27 insertions(+)

Comments

Matthieu Baerts (NGI0) Feb. 21, 2024, 3:40 p.m. UTC | #1

Hi Paolo,

On 21/02/2024 4:32 pm, Paolo Abeni wrote:
> Eric reported and diagnosed another possible deadlock problem with
> the MPTCP diag code. The first patch address the issue, and the second
> adds self-test coverage for the relevant codepath, to get lockdep help
> to catch future similar issues.
> 
> following-up with the netdev fiasco, sending on mptcp only
> 
> v1 -> v2:
>  - fix (avoid) feature detection in patch 2/2 (Matttbe)

Thank you for this v2, it looks good to me!

Reviewed-by: Matthieu Baerts (NGI0) <[e-mail]>

Cheers,
Matt