| Message ID | cover.1716519897.git.tanggeliang@kylinos.cn (mailing list archive) |
|---|---|
| Headers | show |
| Series | use helpers in lib.sh and net_helpers.sh | expand |
Hi Geliang,
Thank you for your modifications, that's great!
Our CI did some validations and here is its report:
- KVM Validation: normal: Success! ✅
- KVM Validation: debug: Success! ✅
- KVM Validation: btf (only bpftest_all): Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/9218177603
Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/3f489d2ea6c4
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=855553
If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:
$ cd [kernel source code]
$ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
--pull always mptcp/mptcp-upstream-virtme-docker:latest \
auto-normal
For more details:
https://github.com/multipath-tcp/mptcp-upstream-virtme-docker
Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)
Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)
From: Geliang Tang <tanggeliang@kylinos.cn> This set uses the public helpers defined in net selftests to replace helpers in mptcp_lib.sh. v3: - address Matt's comments in v2 (thanks, it's very useful.) - don't rename ns in diag.sh, but in lib.sh - ns in get_counter needs to be renamed too - add a ns_name valid check in setup_ns - drop $NS_LIST in mptcp_lib_ns_init - don't drop mptcp_lib_ns_init, use cleanup_ns in it - don't use cleanup_all_ns, still use mptcp_lib_ns_init v2: - only patch 3 updated, mptcp_join.sh, move cleanup_all_ns from cleanup_partial to cleanup, setup_ns will delete existing namespaces automatically. - update commit logs. Geliang Tang (4): selftests: net: rename ns in setup/cleanup_ns selftests: mptcp: rename ns to _ns in get_counter selftests: mptcp: use setup/cleanup_ns helpers selftests: mptcp: use wait_local_port_listen helper tools/testing/selftests/net/lib.sh | 33 +++++++++++------- .../testing/selftests/net/mptcp/mptcp_lib.sh | 34 +++++-------------- 2 files changed, 29 insertions(+), 38 deletions(-)