| Message ID | cover.1729765157.git.tanggeliang@kylinos.cn (mailing list archive) |
|---|---|
| Headers | show |
| Series | Fixes for "use bpf_iter in bpf schedulers" v8 | expand |
Hi Geliang, Thank you for your modifications, that's great! But sadly, our CI spotted some issues with it when trying to build it. You can find more details there: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/11497633619 Status: failure Initiator: Patchew Applier Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/34d3a58b0bfa Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=902633 Feel free to reply to this email if you cannot access logs, if you need some support to fix the error, if this doesn't seem to be caused by your modifications or if the error is a false positive one. Cheers, MPTCP GH Action bot Bot operated by Matthieu Baerts (NGI0 Core)
On Thu, 2024-10-24 at 18:22 +0800, Geliang Tang wrote: > From: Geliang Tang <tanggeliang@kylinos.cn> > > v2: > - Use mptcp_stream_memory_free instead of using > tcp_stream_memory_free. Sorry, I made a mistake. The parameter of sk_stream_memory_free() is ssk (subsocket), not sk (mptcp socket). We should use tcp_stream_memory_free() here, not mptcp_stream_memory_free(). This set is deprecated and rolled back to the previous version (v1): https://patchwork.kernel.org/project/mptcp/cover/cover.1729738008.git.tanggeliang@kylinos.cn/ Thanks, -Geliang > > Fix mptcp_join.sh (22) and packetdrill errors in "use bpf_iter in bpf > schedulers" (v8) reported by CI. > > Depends on: > - "use bpf_iter in bpf schedulers" v8 > > Based-on: <cover.1729676320.git.tanggeliang@kylinos.cn> > > Geliang Tang (3): > Squash to "mptcp: check sk_stream_memory_free in loop" > Squash to "bpf: Export mptcp packet scheduler helpers" > Squash to "selftests/bpf: Add bpf_burst scheduler & test" > > net/mptcp/bpf.c | 7 ++++++- > net/mptcp/protocol.c | 5 +++-- > tools/testing/selftests/bpf/progs/mptcp_bpf_burst.c | 9 +++++---- > 3 files changed, 14 insertions(+), 7 deletions(-) >
From: Geliang Tang <tanggeliang@kylinos.cn> v2: - Use mptcp_stream_memory_free instead of using tcp_stream_memory_free. Fix mptcp_join.sh (22) and packetdrill errors in "use bpf_iter in bpf schedulers" (v8) reported by CI. Depends on: - "use bpf_iter in bpf schedulers" v8 Based-on: <cover.1729676320.git.tanggeliang@kylinos.cn> Geliang Tang (3): Squash to "mptcp: check sk_stream_memory_free in loop" Squash to "bpf: Export mptcp packet scheduler helpers" Squash to "selftests/bpf: Add bpf_burst scheduler & test" net/mptcp/bpf.c | 7 ++++++- net/mptcp/protocol.c | 5 +++-- tools/testing/selftests/bpf/progs/mptcp_bpf_burst.c | 9 +++++---- 3 files changed, 14 insertions(+), 7 deletions(-)