[mptcp-next,v7,00/11] mptcp: use GENL_REQ_ATTR_CHECK in userspace pm

Message

Geliang Tang Jan. 6, 2025, 8:16 a.m. UTC

From: Geliang Tang <[e-mail]>

v7:
 - update set_flags() interface.
 - drop 'info' parameter of userspace_pm_remove_id_zero_address().
 - rebase v6 on top of these changes.

This is a newer version of the series started by Geliang, now making
them more uniform on how the NL errors are set, and giving more hints to
the userspace about what's wrong.

Geliang Tang (6):
  mptcp: userspace pm set_flags id support
  mptcp: drop skb parameter of set_flags
  mptcp: change rem type of set_flags
  mptcp: add local & remote parameters for set_flags
  mptcp: drop info of userspace_pm_remove_id_zero_address
  mptcp: pm: userspace: use GENL_REQ_ATTR_CHECK

Matthieu Baerts (NGI0) (5):
  mptcp: pm: more precise error messages
  mptcp: pm: use NL_SET_ERR_MSG_ATTR when possible
  mptcp: pm: improve error messages
  mptcp: pm: remove duplicated error messages
  mptcp: pm: mark missing address attributes

 net/mptcp/pm.c           |   8 +-
 net/mptcp/pm_netlink.c   | 107 +++++++++++++++++--------
 net/mptcp/pm_userspace.c | 165 ++++++++++++++++++++-------------------
 net/mptcp/protocol.h     |  12 ++-
 4 files changed, 171 insertions(+), 121 deletions(-)

Comments

MPTCP CI Jan. 6, 2025, 9:20 a.m. UTC | #1

Hi Matthieu,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal: Unstable: 1 failed test(s): selftest_userspace_pm - Critical: 1 Call Trace(s) ❌
- KVM Validation: debug: Unstable: 2 failed test(s): packetdrill_fastopen selftest_userspace_pm - Critical: 1 Call Trace(s) ❌
- KVM Validation: btf-normal (only bpftest_all): Success! ✅
- KVM Validation: btf-debug (only bpftest_all): Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/12629204806

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/1230ba468eda
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=922462


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-normal

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)