| Message ID | cover.1740019794.git.tanggeliang@kylinos.cn (mailing list archive) |
|---|---|
| Headers | show |
| Series | BPF path manager, part 4 | expand |
Hi Geliang, Thank you for your modifications, that's great! Our CI did some validations and here is its report: - KVM Validation: normal: Success! ✅ - KVM Validation: debug: Success! ✅ - KVM Validation: btf-normal (only bpftest_all): Success! ✅ - KVM Validation: btf-debug (only bpftest_all): Unstable: 1 failed test(s): bpftest_test_progs-no_alu32_mptcp
Hi Geliang, On 20/02/2025 03:57, Geliang Tang wrote: > From: Geliang Tang <tanggeliang@kylinos.cn> > > v5: > - use "struct mptcp_pm_param *param" as unified parameters for all > interfaces. > - register in-kernel mptcp_pm_ops too. > - only implement two interfaces "get_local_id" and "get_priority" in > this set. > > v4: > - include a new patch "define BPF path manager type". > > - add new interfaces: > created established closed > listerner_created listener_closed > > - rename interfaces as: > address_announced address_removed > subflow_established subflow_closed > get_priority set_priority > > - rename functions as: > mptcp_pm_validate > mptcp_pm_register > mptcp_pm_unregister > mptcp_pm_initialize > mptcp_pm_release Thank you for the new PM ops, and the different modifications, that looks clearer! I have some comments, mainly about the new "struct mptcp_pm_param *param" that seems causing more issues (noises) than solving some I think. Please see my individual comments. Cheers, Matt
From: Geliang Tang <tanggeliang@kylinos.cn> v5: - use "struct mptcp_pm_param *param" as unified parameters for all interfaces. - register in-kernel mptcp_pm_ops too. - only implement two interfaces "get_local_id" and "get_priority" in this set. v4: - include a new patch "define BPF path manager type". - add new interfaces: created established closed listerner_created listener_closed - rename interfaces as: address_announced address_removed subflow_established subflow_closed get_priority set_priority - rename functions as: mptcp_pm_validate mptcp_pm_register mptcp_pm_unregister mptcp_pm_initialize mptcp_pm_release v3: - rename the 2nd parameter of get_local_id() from 'local' to 'skc'. - keep the 'msk_sport' check in mptcp_userspace_pm_get_local_id(). - return 'err' instead of '0' in userspace_pm_subflow_create(). - drop 'ret' variable inmptcp_pm_data_reset(). - fix typos in commit log. v2: - update get_local_id interface in patch 2. get_addr() and dump_addr() interfaces of BPF userspace pm are dropped as Matt suggested. In order to implement BPF path manager, it's necessary to unify the interfaces of the path manager. This set contains some cleanups and refactoring to unify the interfaces in kernel space. Finally, define a struct mptcp_pm_ops for a path manager. Geliang Tang (9): mptcp: pm: use addr entry for get_local_id mptcp: pm: add struct mptcp_pm_param mptcp: pm: pass pm_param to get_local_id mptcp: pm: define struct mptcp_pm_ops mptcp: pm: in-kernel: register mptcp_netlink_pm mptcp: pm: userspace: register mptcp_userspace_pm mptcp: pm: initialize and release mptcp_pm_ops mptcp: pm: drop get_local_id helpers mptcp: pm: drop is_backup helpers include/net/mptcp.h | 42 +++++++++++++ net/mptcp/pm.c | 131 ++++++++++++++++++++++++++++++++++++--- net/mptcp/pm_netlink.c | 23 +++++-- net/mptcp/pm_userspace.c | 37 ++++++----- net/mptcp/protocol.c | 1 + net/mptcp/protocol.h | 24 +++---- 6 files changed, 216 insertions(+), 42 deletions(-)