[mptcp-next,v3,0/2] selftests: mptcp: add tests for increasing

Message

Gang Yan Feb. 21, 2025, 5:34 a.m. UTC

These patches provide a method to verify the 'mptcp_diag_dump_one'
function, and the new tool 'mptcp_diag' can get the specific mptcp_info
through multi msks.

Gang Yan (2):
  selftests: mptcp: Add a tool to get specific msk_info
  selftests: mptcp: add a test for mptcp_diag_dump_one

 tools/testing/selftests/net/mptcp/Makefile    |   2 +-
 tools/testing/selftests/net/mptcp/diag.sh     |  27 ++
 .../testing/selftests/net/mptcp/mptcp_diag.c  | 258 ++++++++++++++++++
 3 files changed, 286 insertions(+), 1 deletion(-)
 create mode 100644 tools/testing/selftests/net/mptcp/mptcp_diag.c

Comments

MPTCP CI Feb. 21, 2025, 6:41 a.m. UTC | #1

Hi Gang,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal: Unstable: 1 failed test(s): selftest_mptcp_connect 

Matthieu Baerts Feb. 21, 2025, 11:54 a.m. UTC | #2

Hi Gang Yan,

On 21/02/2025 06:34, Gang Yan wrote:
> These patches provide a method to verify the 'mptcp_diag_dump_one'
> function, and the new tool 'mptcp_diag' can get the specific mptcp_info
> through multi msks.

Thank you for the new version.

Please always add a changelog in case of new version to help the
reviewers, and making sure you didn't miss anything. Ideally, the cover
letter should mention which patches have been modified, and each patch
should have a changelog in the comments (add '---' under the last
Signed-off-by, then the changelog, or use 'git notes' and 'git
format-patch --notes')

Cheers,
Matt