| Message ID | cover.1740320007.git.tanggeliang@kylinos.cn (mailing list archive) |
|---|---|
| Headers | show |
| Series | BPF path manager, part 4 | expand |
Hi Geliang, Thank you for your modifications, that's great! But sadly, our CI spotted some issues with it when trying to build it. You can find more details there: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/13484061885 Status: failure Initiator: Patchew Applier Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/ba9a44169d90 Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=936802 Feel free to reply to this email if you cannot access logs, if you need some support to fix the error, if this doesn't seem to be caused by your modifications or if the error is a false positive one. Cheers, MPTCP GH Action bot Bot operated by Matthieu Baerts (NGI0 Core)
Hi Geliang,
Thank you for your modifications, that's great!
Our CI did some validations and here is its report:
- KVM Validation: normal: Success! ✅
- KVM Validation: debug: Success! ✅
- KVM Validation: btf-normal (only bpftest_all): Success! ✅
- KVM Validation: btf-debug (only bpftest_all): Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/13484061884
Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/ba9a44169d90
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=936802
If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:
$ cd [kernel source code]
$ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
--pull always mptcp/mptcp-upstream-virtme-docker:latest \
auto-normal
For more details:
https://github.com/multipath-tcp/mptcp-upstream-virtme-docker
Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)
Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)
From: Geliang Tang <tanggeliang@kylinos.cn> v6: - add "name" in struct mptcp_pm_ops. - add some "sysctl" patches. - drop "struct mptcp_pm_param". - drop "pm_type" in mptcp_pm_data. v5: - use "struct mptcp_pm_param *param" as unified parameters for all interfaces. - register in-kernel mptcp_pm_ops too. - only implement two interfaces "get_local_id" and "get_priority" in this set. v4: - include a new patch "define BPF path manager type". - add new interfaces: created established closed listerner_created listener_closed - rename interfaces as: address_announced address_removed subflow_established subflow_closed get_priority set_priority - rename functions as: mptcp_pm_validate mptcp_pm_register mptcp_pm_unregister mptcp_pm_initialize mptcp_pm_release v3: - rename the 2nd parameter of get_local_id() from 'local' to 'skc'. - keep the 'msk_sport' check in mptcp_userspace_pm_get_local_id(). - return 'err' instead of '0' in userspace_pm_subflow_create(). - drop 'ret' variable inmptcp_pm_data_reset(). - fix typos in commit log. v2: - update get_local_id interface in patch 2. get_addr() and dump_addr() interfaces of BPF userspace pm are dropped as Matt suggested. In order to implement BPF path manager, it's necessary to unify the interfaces of the path manager. This set contains some cleanups and refactoring to unify the interfaces in kernel space. Finally, define a struct mptcp_pm_ops for a path manager. Geliang Tang (13): mptcp: sysctl: use index for sysctl table mptcp: sysctl: add path_manager to set pm name mptcp: pm: use addr entry for get_local_id mptcp: pm: define struct mptcp_pm_ops mptcp: pm: in-kernel: register mptcp_in_kernel_pm mptcp: pm: userspace: register mptcp_userspace_pm mptcp: pm: initialize and release mptcp_pm_ops mptcp: pm: drop pm_type in mptcp_pm_data mptcp: sysctl: drop old pm_type sysctl mptcp: sysctl: add available_path_managers mptcp: pm: drop get_local_id helpers mptcp: pm: drop is_backup helpers selftests/mptcp: use path_manager instead of pm_type Documentation/networking/mptcp-sysctl.rst | 14 +- include/net/mptcp.h | 39 +++++ net/mptcp/ctrl.c | 104 ++++++++++--- net/mptcp/pm.c | 141 ++++++++++++++++-- net/mptcp/pm_netlink.c | 24 ++- net/mptcp/pm_userspace.c | 36 +++-- net/mptcp/protocol.c | 1 + net/mptcp/protocol.h | 23 ++- .../testing/selftests/net/mptcp/mptcp_join.sh | 26 ++-- .../selftests/net/mptcp/userspace_pm.sh | 4 +- 10 files changed, 324 insertions(+), 88 deletions(-)