| Message ID | cover.1740384564.git.tanggeliang@kylinos.cn (mailing list archive) |
|---|---|
| Headers | show |
| Series | BPF path manager, part 4 | expand |
Hi Geliang,
Thank you for your modifications, that's great!
Our CI did some validations and here is its report:
- KVM Validation: normal: Success! ✅
- KVM Validation: debug: Success! ✅
- KVM Validation: btf-normal (only bpftest_all): Success! ✅
- KVM Validation: btf-debug (only bpftest_all): Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/13493747167
Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/51a90b40c97b
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=936935
If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:
$ cd [kernel source code]
$ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
--pull always mptcp/mptcp-upstream-virtme-docker:latest \
auto-normal
For more details:
https://github.com/multipath-tcp/mptcp-upstream-virtme-docker
Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)
Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)
Hi Geliang, On 24/02/2025 09:13, Geliang Tang wrote: > From: Geliang Tang <tanggeliang@kylinos.cn> > > Some path manager related refactoring and cleanups. > > Geliang Tang (6): > mptcp: pm: in-kernel: avoid access entry without lock > mptcp: pm: in-kernel: reduce parameters of set_flags > mptcp: pm: use addr entry for get_local_id For these 3 patches above: Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org> > mptcp: pm: in-kernel: use kmemdup helper > sock: add sock_kmemdup helper > mptcp: pm: userspace: use sock_kmemdup helper > > include/net/sock.h | 1 + > net/core/sock.c | 23 +++++++++++++++++++++++ > net/mptcp/pm.c | 9 ++++++--- > net/mptcp/pm_netlink.c | 30 +++++++++++++----------------- > net/mptcp/pm_userspace.c | 20 +++++++------------- > net/mptcp/protocol.h | 6 ++++-- > 6 files changed, 54 insertions(+), 35 deletions(-) Cheers, Matt
Hi Geliang, On 24/02/2025 12:05, Matthieu Baerts wrote: > Hi Geliang, > > On 24/02/2025 09:13, Geliang Tang wrote: >> From: Geliang Tang <tanggeliang@kylinos.cn> >> >> Some path manager related refactoring and cleanups. >> >> Geliang Tang (6): >> mptcp: pm: in-kernel: avoid access entry without lock >> mptcp: pm: in-kernel: reduce parameters of set_flags >> mptcp: pm: use addr entry for get_local_id > > For these 3 patches above: > > Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org> These 3 patches are now in our tree (feat. for next), with the proper SHA in the Fixes tag for the first patch: New patches for t/upstream: - c8a2f8c2afac: mptcp: pm: in-kernel: avoid access entry without lock - 91606b7d16da: mptcp: pm: in-kernel: reduce parameters of set_flags - 29b6fd0cf693: mptcp: pm: use addr entry for get_local_id - Results: 1238896935ea..3635c12a532c (export) Tests are now in progress: - export: https://github.com/multipath-tcp/mptcp_net-next/commit/100f5ffc0c317c10656b1397607f52d95d0d8911/checks Note that there was a small conflict with "mptcp: fix 'scheduling while atomic' in mptcp_pm_nl_append_new_local_addr". Cheers, Matt
From: Geliang Tang <tanggeliang@kylinos.cn> Some path manager related refactoring and cleanups. Geliang Tang (6): mptcp: pm: in-kernel: avoid access entry without lock mptcp: pm: in-kernel: reduce parameters of set_flags mptcp: pm: use addr entry for get_local_id mptcp: pm: in-kernel: use kmemdup helper sock: add sock_kmemdup helper mptcp: pm: userspace: use sock_kmemdup helper include/net/sock.h | 1 + net/core/sock.c | 23 +++++++++++++++++++++++ net/mptcp/pm.c | 9 ++++++--- net/mptcp/pm_netlink.c | 30 +++++++++++++----------------- net/mptcp/pm_userspace.c | 20 +++++++------------- net/mptcp/protocol.h | 6 ++++-- 6 files changed, 54 insertions(+), 35 deletions(-)