[mptcp-next,v4,0/2] selftests: mptcp: add tests for increasing

Message

Gang Yan Feb. 24, 2025, 9:02 a.m. UTC

These patches provide a method to verify the 'mptcp_diag_dump_one'
function, and the new tool 'mptcp_diag' can get the specific mptcp_info
through multi msks.

Hi Matt:

Thank you for your suggestions regarding these patches, they have been
very useful to me. Sorry for the misunderstanding caused by my misuse of
the 'CLOSE' keyword. Currently, I have used the 'Link' instead. These 
patches are designed for 'mptcp_dump_one'.

There may need another test case for 'subflow_get_info_size'. I will 
continue to work on resolving this issue.

Best wishes!

Gang Yan (2):
  selftests: mptcp: Add a tool to get specific msk_info
  selftests: mptcp: add a test for mptcp_diag_dump_one

 tools/testing/selftests/net/mptcp/Makefile    |   2 +-
 tools/testing/selftests/net/mptcp/diag.sh     |  27 ++
 .../testing/selftests/net/mptcp/mptcp_diag.c  | 271 ++++++++++++++++++
 3 files changed, 299 insertions(+), 1 deletion(-)
 create mode 100644 tools/testing/selftests/net/mptcp/mptcp_diag.c

Comments

MPTCP CI Feb. 24, 2025, 10:06 a.m. UTC | #1

Hi Gang,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal: Success! ✅
- KVM Validation: debug: Success! ✅
- KVM Validation: btf-normal (only bpftest_all): Success! ✅
- KVM Validation: btf-debug (only bpftest_all): Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/13494531915

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/07791475cb37
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=936949


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-normal

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)

Matthieu Baerts Feb. 24, 2025, 12:13 p.m. UTC | #2

Hi Gang Yan,

On 24/02/2025 10:02, Gang Yan wrote:
> These patches provide a method to verify the 'mptcp_diag_dump_one'
> function, and the new tool 'mptcp_diag' can get the specific mptcp_info
> through multi msks.

Thank you for the update.

It looks good to me, just 2 small comments, but I can do the
modifications when applying the patches, no need to send a v5 just for that.

Reviewed-by: Matthieu Baerts (NGI0) <[e-mail]>

> Hi Matt:
> 
> Thank you for your suggestions regarding these patches, they have been
> very useful to me. Sorry for the misunderstanding caused by my misuse of
> the 'CLOSE' keyword. Currently, I have used the 'Link' instead. These 
> patches are designed for 'mptcp_dump_one'.
> 
> There may need another test case for 'subflow_get_info_size'. I will 
> continue to work on resolving this issue.
OK, Great!

Cheers,
Matt

Matthieu Baerts Feb. 24, 2025, 12:23 p.m. UTC | #3

On 24/02/2025 13:13, Matthieu Baerts wrote:
> Hi Gang Yan,
> 
> On 24/02/2025 10:02, Gang Yan wrote:
>> These patches provide a method to verify the 'mptcp_diag_dump_one'
>> function, and the new tool 'mptcp_diag' can get the specific mptcp_info
>> through multi msks.
> 
> Thank you for the update.
> 
> It looks good to me, just 2 small comments, but I can do the
> modifications when applying the patches, no need to send a v5 just for that.
> 
> Reviewed-by: Matthieu Baerts (NGI0) <[e-mail]>

Now in our tree:

New patches for t/upstream:
- 07774a3ae41c: selftests: mptcp: Add a tool to get specific msk_info
- 24f7b212d821: selftests: mptcp: add a test for mptcp_diag_dump_one
- Results: 192ee51a45e8..3716d837622e (export)

Tests are now in progress:

- export:
https://github.com/multipath-tcp/mptcp_net-next/commit/e839bf51efe24a9e4f30676f620777d253e6add3/checks

Cheers,
Matt