| Message ID | cover.1741226722.git.tanggeliang@kylinos.cn (mailing list archive) |
|---|---|
| Headers | show |
| Series | cleanups for bpf schedulers | expand |
Hi Geliang,
Thank you for your modifications, that's great!
Our CI did some validations and here is its report:
- KVM Validation: normal: Success! ✅
- KVM Validation: debug: Success! ✅
- KVM Validation: btf-normal (only bpftest_all): Success! ✅
- KVM Validation: btf-debug (only bpftest_all): Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/13689905745
Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/4b6403c184b4
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=940810
If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:
$ cd [kernel source code]
$ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
--pull always mptcp/mptcp-upstream-virtme-docker:latest \
auto-normal
For more details:
https://github.com/multipath-tcp/mptcp-upstream-virtme-docker
Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)
Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)
Hi Geliang, Mat, On 06/03/2025 03:15, Geliang Tang wrote: > From: Geliang Tang <tanggeliang@kylinos.cn> > > 1. Add validate_scheduler. > 2. Drop mptcp_sched_find in bpf_mptcp_sched_init_member. > 3. Drop mptcp_sock_type and mptcp_subflow_type. > 4. Move netns_new() out of sched_init(). > 5. Use .struct_ops.link instead of .struct_ops. Thank you for this series and the reviews! Now in our tree (feat. for net-next for the first patch): New patches for t/upstream: - d4c306a43b3f: mptcp: add mptcp_validate_scheduler helper - Results: f919d66019d7..3401ddbacc79 (export) - 59ab4747927b: "squashed" patch 2/8 in "bpf: Add bpf_mptcp_sched_ops" - 38fdfd5cba1b: tg:msg: adapt 'bpf: Add mptcp packet scheduler struct_ops' - a1aaa0e29d01: "squashed" patch 3/8 in "selftests/bpf: Add bpf scheduler test" - 99b384565fb2: return directly as suggested by Mat - 354174f5423a: "squashed" patch 4/8 in "selftests/bpf: Add bpf_first scheduler & test" - 7f16e3788029: "squashed" patch 5/8 in "selftests/bpf: Add bpf_bkup scheduler & test" - 8d85ef2f3be9: "squashed" patch 6/8 in "selftests/bpf: Add bpf_rr scheduler & test" - 72ecea93b815: "squashed" patch 7/8 in "selftests/bpf: Add bpf_red scheduler & test" - 16789699fd1b: "squashed" patch 8/8 in "selftests/bpf: Add bpf_burst scheduler & test" - Results: 3401ddbacc79..35f3f56f1201 (export) Tests are now in progress: - export: https://github.com/multipath-tcp/mptcp_net-next/commit/0404035380f85690b46bcb554e872f638ca9ee56/checks Cheers, Matt
From: Geliang Tang <tanggeliang@kylinos.cn> 1. Add validate_scheduler. 2. Drop mptcp_sched_find in bpf_mptcp_sched_init_member. 3. Drop mptcp_sock_type and mptcp_subflow_type. 4. Move netns_new() out of sched_init(). 5. Use .struct_ops.link instead of .struct_ops. Geliang Tang (8): mptcp: add mptcp_validate_scheduler helper Squash to "bpf: Add bpf_mptcp_sched_ops" Squash to "selftests/bpf: Add bpf scheduler test" Squash to "selftests/bpf: Add bpf_first scheduler & test" Squash to "selftests/bpf: Add bpf_bkup scheduler & test" Squash to "selftests/bpf: Add bpf_rr scheduler & test" Squash to "selftests/bpf: Add bpf_red scheduler & test" Squash to "selftests/bpf: Add bpf_burst scheduler & test" net/mptcp/bpf.c | 32 +++++++------ net/mptcp/protocol.h | 1 + net/mptcp/sched.c | 17 ++++++- .../testing/selftests/bpf/prog_tests/mptcp.c | 45 ++++++++++--------- tools/testing/selftests/bpf/progs/mptcp_bpf.h | 3 -- .../selftests/bpf/progs/mptcp_bpf_bkup.c | 2 +- .../selftests/bpf/progs/mptcp_bpf_burst.c | 10 ++--- .../selftests/bpf/progs/mptcp_bpf_first.c | 2 +- .../selftests/bpf/progs/mptcp_bpf_red.c | 2 +- .../selftests/bpf/progs/mptcp_bpf_rr.c | 2 +- 10 files changed, 63 insertions(+), 53 deletions(-)