[mptcp-next,v2,00/10] BPF path manager, part 6

Message

Geliang Tang March 14, 2025, 2:45 a.m. UTC

From: Geliang Tang <[e-mail]>

v2:
- address Matt's comments in v1.
- add add_addr_received and rm_addr_received interfaces.
- drop subflow_check_next interface.
- add a "required" or "optional" comment for a group of interfaces in
  struct mptcp_pm_ops.

v1:
- https://patchwork.kernel.org/project/mptcp/cover/[e-mail]/

New interfaces for struct mptcp_pm_ops.

Geliang Tang (10):
  mptcp: pm: drop redundant MPTCP_MIB_ADDADDRDROP
  Squash to "mptcp: pm: add get_local_id() interface"
  mptcp: pm: add established() interface
  mptcp: pm: add subflow_established() interface
  mptcp: pm: add allow_new_subflow() interface
  mptcp: pm: add accept_new_subflow() interface
  mptcp: pm: add add_addr_received() interface
  mptcp: pm: add add_addr_echo() interface
  mptcp: pm: add rm_addr_received() interface
  mptcp: pm: drop is_userspace in subflow_check_next

 include/net/mptcp.h      |  16 ++++++
 net/mptcp/pm.c           | 112 +++++++++++++++++----------------------
 net/mptcp/pm_kernel.c    |  74 ++++++++++++++++++++++----
 net/mptcp/pm_userspace.c |  27 ++++++++++
 net/mptcp/protocol.h     |   4 ++
 net/mptcp/subflow.c      |   4 +-
 6 files changed, 161 insertions(+), 76 deletions(-)

Comments

MPTCP CI March 14, 2025, 3:57 a.m. UTC | #1

Hi Geliang,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal: Success! ✅
- KVM Validation: debug: Success! ✅
- KVM Validation: btf-normal (only bpftest_all): Success! ✅
- KVM Validation: btf-debug (only bpftest_all): Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/13848993575

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/b5c3186d7405
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=943747


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-normal

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)