Message ID | cover.1742364129.git.tanggeliang@kylinos.cn (mailing list archive) |
---|---|
Headers | show |
Series | cleanups for main_loop | expand |
Hi Geliang, Thank you for your modifications, that's great! Our CI did some validations and here is its report: - KVM Validation: normal: Success! ✅ - KVM Validation: debug: Success! ✅ - KVM Validation: btf-normal (only bpftest_all): Success! ✅ - KVM Validation: btf-debug (only bpftest_all): Unstable: 1 failed test(s): bpftest_test_progs-no_alu32_mptcp
Hi Geliang, On 19/03/2025 07:08, Geliang Tang wrote: > From: Geliang Tang <tanggeliang@kylinos.cn> > > v3: > - don't remove the second "open(cfg_input)", it breaks the disconnect > tests. > - no need to "close(fd)" when copyfd_io fails. Thank you for the v3! Now in our tree (fixes for -net) New patches for t/upstream-net and t/upstream: - 13f5f942f351: selftests: mptcp: close fd_in before returning in main_loop - Results: d875e1a7561c..d9132f531a99 (export-net) - Results: 148c72298499..f919d66019d7 (export) Tests are now in progress: - export-net: https://github.com/multipath-tcp/mptcp_net-next/commit/bf609846189a78f7c1b12715143f53e747f9798e/checks - export: https://github.com/multipath-tcp/mptcp_net-next/commit/6b987b570b6ee0670d23bb5dd7d9d14ae680ac9c/checks Cheers, Matt
From: Geliang Tang <tanggeliang@kylinos.cn> v3: - don't remove the second "open(cfg_input)", it breaks the disconnect tests. - no need to "close(fd)" when copyfd_io fails. Based-on: <59caf78b9d67a0a61a19a46f7820456f6ced3d6e.1742296236.git.tanggeliang@kylinos.cn> v2: - update the pending patches from Cong Liu, he said to me that he has no time to deal with this recently. - delete the second "open(cfg_input)" instead of the first one as Matt suggested. - drop freeaddrinfo, no need to do this. - https://patchwork.kernel.org/project/mptcp/cover/cover.1742355162.git.tanggeliang@kylinos.cn/ v1: - https://patchwork.kernel.org/project/mptcp/cover/20250113085228.121778-1-liucong2@kylinos.cn/ Geliang Tang (1): selftests: mptcp: close fd_in before returning in main_loop tools/testing/selftests/net/mptcp/mptcp_connect.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)