[mptcp-next,v1,0/4] BPF path manager, part 7

Message

Geliang Tang March 21, 2025, 1:49 a.m. UTC

From: Geliang Tang <[e-mail]>

Add mptcp bpf_netlink pm subtest.

Depends on:
 - BPF path manager, part 6, v3

Based-on: <[e-mail]>

Geliang Tang (4):
  bpf: Add mptcp path manager struct_ops
  bpf: Export mptcp path manager kfuncs
  selftests/bpf: Add mptcp netlink pm subtest
  selftests/bpf: Add mptcp bpf_netlink pm subtest

 net/mptcp/bpf.c                               | 307 +++++++++++++++++-
 net/mptcp/pm_kernel.c                         |  27 ++
 .../testing/selftests/bpf/prog_tests/mptcp.c  | 284 ++++++++++++++++
 tools/testing/selftests/bpf/progs/mptcp_bpf.h |  27 ++
 .../bpf/progs/mptcp_bpf_netlink_pm.c          | 204 ++++++++++++
 .../selftests/bpf/progs/mptcp_bpf_pm.h        |  52 +++
 6 files changed, 900 insertions(+), 1 deletion(-)
 create mode 100644 tools/testing/selftests/bpf/progs/mptcp_bpf_netlink_pm.c
 create mode 100644 tools/testing/selftests/bpf/progs/mptcp_bpf_pm.h

Comments

MPTCP CI March 21, 2025, 2:20 a.m. UTC | #1

Hi Geliang,

Thank you for your modifications, that's great!

But sadly, our CI spotted some issues with it when trying to build it.

You can find more details there:

  https://github.com/multipath-tcp/mptcp_net-next/actions/runs/13983028068

Status: failure
Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/0d2604c2d943
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=946095

Feel free to reply to this email if you cannot access logs, if you need
some support to fix the error, if this doesn't seem to be caused by your
modifications or if the error is a false positive one.

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)

MPTCP CI March 21, 2025, 2:59 a.m. UTC | #2

Hi Geliang,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal: Success! ✅
- KVM Validation: debug: Success! ✅
- KVM Validation: btf-normal (only bpftest_all): Success! ✅
- KVM Validation: btf-debug (only bpftest_all): Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/13983028079

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/0d2604c2d943
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=946095


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-normal

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)