| Message ID | 20250317-mptcp-sft-diag-ignore-v1-1-d1e7ec9ff89a@kernel.org (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Commit | 67fefa933291715905f260681753f7e029e194ac |
| Delegated to: | Matthieu Baerts |
| Headers | show |
| Series | [mptcp-next] selftests: mptcp: ignore mptcp_diag binary | expand |
| Context | Check | Description |
|---|---|---|
| matttbe/build | success | Build and static analysis OK |
| matttbe/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 6 lines checked |
| matttbe/shellcheck | success | MPTCP selftests files have not been modified |
| matttbe/KVM_Validation__normal | success | Success! ✅ |
| matttbe/KVM_Validation__debug | success | Success! ✅ |
| matttbe/KVM_Validation__btf-normal__only_bpftest_all_ | success | Success! ✅ |
| matttbe/KVM_Validation__btf-debug__only_bpftest_all_ | warning | Unstable: 1 failed test(s): bpftest_test_progs-no_alu32_mptcp |
Hi Matthieu, Thank you for your modifications, that's great! Our CI did some validations and here is its report: - KVM Validation: normal: Success! ✅ - KVM Validation: debug: Success! ✅ - KVM Validation: btf-normal (only bpftest_all): Success! ✅ - KVM Validation: btf-debug (only bpftest_all): Unstable: 1 failed test(s): bpftest_test_progs-no_alu32_mptcp
On Mon, 17 Mar 2025, Matthieu Baerts (NGI0) wrote: > A new binary is now generated by the MPTCP selftests: mptcp_diag. > > Like the other binaries from this directory, there is no need to track > this in Git, it should then be ignored. > > Fixes: 00f5e338cf7e ("selftests: mptcp: Add a tool to get specific msk_info") > Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org> LGTM: Reviewed-by: Mat Martineau <martineau@kernel.org> > --- > tools/testing/selftests/net/mptcp/.gitignore | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/testing/selftests/net/mptcp/.gitignore b/tools/testing/selftests/net/mptcp/.gitignore > index 49daae73c41e6f86c6f0e47aa42426e5ad5c17e6..833279fb34e2dd74a27f16c26e44108029dd45e1 100644 > --- a/tools/testing/selftests/net/mptcp/.gitignore > +++ b/tools/testing/selftests/net/mptcp/.gitignore > @@ -1,5 +1,6 @@ > # SPDX-License-Identifier: GPL-2.0-only > mptcp_connect > +mptcp_diag > mptcp_inq > mptcp_sockopt > pm_nl_ctl > > --- > base-commit: 098b800967a7a5aa1a5d80f934893dc95784f1d8 > change-id: 20250317-mptcp-sft-diag-ignore-bb66d21eb585 > > Best regards, > -- > Matthieu Baerts (NGI0) <matttbe@kernel.org> > > >
Hi Mat, On 18/03/2025 02:17, Mat Martineau wrote: > On Mon, 17 Mar 2025, Matthieu Baerts (NGI0) wrote: > >> A new binary is now generated by the MPTCP selftests: mptcp_diag. >> >> Like the other binaries from this directory, there is no need to track >> this in Git, it should then be ignored. >> >> Fixes: 00f5e338cf7e ("selftests: mptcp: Add a tool to get specific >> msk_info") >> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org> > > LGTM: > > Reviewed-by: Mat Martineau <martineau@kernel.org> Thank you! Now in our tree: New patches for t/upstream: - 67fefa933291: selftests: mptcp: ignore mptcp_diag binary - Results: 8b41d802004a..8131e8aff41d (export) Tests are now in progress: - export: https://github.com/multipath-tcp/mptcp_net-next/commit/c82c9438b7e32f95e7e5c10851b9b49128f043a6/checks Cheers, Matt
diff --git a/tools/testing/selftests/net/mptcp/.gitignore b/tools/testing/selftests/net/mptcp/.gitignore index 49daae73c41e6f86c6f0e47aa42426e5ad5c17e6..833279fb34e2dd74a27f16c26e44108029dd45e1 100644 --- a/tools/testing/selftests/net/mptcp/.gitignore +++ b/tools/testing/selftests/net/mptcp/.gitignore @@ -1,5 +1,6 @@ # SPDX-License-Identifier: GPL-2.0-only mptcp_connect +mptcp_diag mptcp_inq mptcp_sockopt pm_nl_ctl
A new binary is now generated by the MPTCP selftests: mptcp_diag. Like the other binaries from this directory, there is no need to track this in Git, it should then be ignored. Fixes: 00f5e338cf7e ("selftests: mptcp: Add a tool to get specific msk_info") Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org> --- tools/testing/selftests/net/mptcp/.gitignore | 1 + 1 file changed, 1 insertion(+) --- base-commit: 098b800967a7a5aa1a5d80f934893dc95784f1d8 change-id: 20250317-mptcp-sft-diag-ignore-bb66d21eb585 Best regards,