From patchwork Thu Feb 27 08:23:25 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Geliang Tang X-Patchwork-Id: 13993894 X-Patchwork-Delegate: matthieu.baerts@tessares.net Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A31D222574; Thu, 27 Feb 2025 08:24:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740644649; cv=none; b=ZlFJ1ou9dSOkuiMfLPxAgbUOG3zrrWbG0c2d/NyxdteTi1pP7S7D08zniuPfhR8/Khr86HoNQzVNTZq/yKjFz7+IH2wG8vni1nu4QxRmQG1DjsTNPwNvUC0UEiKkMaeQfX4sOZjO3s7VVO1Y9rDyoMGp30tnsopiWCV0XAtRQsM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740644649; c=relaxed/simple; bh=74yTkQnIWdu4oYvGKAnTJbzZweABw7andTw5FBDDA0U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QTuiL5G9/wwrx5lrq8KSarZvkfo9sjdRphWATO0itRSNonubW/j+Jaiq3MkkEcXKxmyyFdia/KD5WPgEGM2fxyG4IHPHsUmqFzjWcMli07ykPCRNkx/42NF69sRYfRhyodTNj/HW/10Muc/0y9J+5rPOw0rRZOcFBfVF94q4JXI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=AWCGc4ME; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="AWCGc4ME" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CB090C4CEEB; Thu, 27 Feb 2025 08:24:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740644648; bh=74yTkQnIWdu4oYvGKAnTJbzZweABw7andTw5FBDDA0U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AWCGc4MEuW3QSbpqvjWpyIRZSLCIgRpIcmUbkVcTLrvHb79RnGutD4NvJibMJWYMY hmu0VeZkwjMFQMYj5Jx7TAmkDpRBqphMueNXW05BJOsO6gCgxvet2l+cShtP788zDr otvIaa0xJ3VWfR6y8/QGymAUPAVP2JUPIMdrSIhiKAQLrQRYoGXF0OMw/C8q3VYpyJ MsytYk/r+mvx4aauv3vkSpvHTELZnwf3XbKzohE9IlsVcRz7nZ9BJSwGWHtGtVNV2S BR4YnFGjMamT3id6H1NNgQSyLzMtiAUvzR/oostbCAzUUohhmL5okmQn0onp8VZkGF 1J7/udNDMQhwQ== From: Geliang Tang To: Eric Dumazet , Kuniyuki Iwashima , Paolo Abeni , Willem de Bruijn , "David S. Miller" , Jakub Kicinski , Simon Horman , Neal Cardwell , David Ahern , Matthieu Baerts , Mat Martineau , Marcelo Ricardo Leitner , Xin Long Cc: Geliang Tang , netdev@vger.kernel.org, mptcp@lists.linux.dev, linux-sctp@vger.kernel.org Subject: [PATCH net-next 3/4] mptcp: use sock_kmemdup for address entry Date: Thu, 27 Feb 2025 16:23:25 +0800 Message-ID: <35aeccb53a34ac50abe54dcb4e4cbaec66e3ae11.1740643844.git.tanggeliang@kylinos.cn> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Geliang Tang Instead of using sock_kmalloc() to allocate an address entry "e" and then immediately duplicate the input "entry" to it, the newly added sock_kmemdup() helper can be used in mptcp_userspace_pm_append_new_local_addr() to simplify the code. More importantly, the code "*e = *entry;" that assigns "entry" to "e" is not easy to implemented in BPF if we use the same code to implement an append_new_local_addr() helper of a BFP path manager. This patch avoids this type of memory assignment operation. Signed-off-by: Geliang Tang --- net/mptcp/pm_userspace.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/mptcp/pm_userspace.c b/net/mptcp/pm_userspace.c index 6bf6a20ef7f3..7e7d01bef5d4 100644 --- a/net/mptcp/pm_userspace.c +++ b/net/mptcp/pm_userspace.c @@ -71,13 +71,12 @@ static int mptcp_userspace_pm_append_new_local_addr(struct mptcp_sock *msk, /* Memory for the entry is allocated from the * sock option buffer. */ - e = sock_kmalloc(sk, sizeof(*e), GFP_ATOMIC); + e = sock_kmemdup(sk, entry, sizeof(*entry), GFP_ATOMIC); if (!e) { ret = -ENOMEM; goto append_err; } - *e = *entry; if (!e->addr.id && needs_id) e->addr.id = find_next_zero_bit(id_bitmap, MPTCP_PM_MAX_ADDR_ID + 1,