| Message ID | 50740f793884616dd10374327029408dcd25dacc.1707739536.git.pabeni@redhat.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Delegated to: | Mat Martineau |
| Headers | show |
| Series | mptcp: implement TCP_NOTSENT_LOWAT support | expand |
| Context | Check | Description |
|---|---|---|
| matttbe/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 7 lines checked |
| matttbe/build | success | Build and static analysis OK |
| matttbe/KVM_Validation__normal | success | Success! ✅ |
| matttbe/KVM_Validation__debug__except_selftest_mptcp_join_ | success | Success! ✅ |
| matttbe/KVM_Validation__debug__only_selftest_mptcp_join_ | success | Success! ✅ |
On Mon, 12 Feb 2024, Paolo Abeni wrote: > when inserting not contiguous data in the subflow write queue, > the protocol creates a new skb and prevent the TCP stack from > merging it later with already queued skbs by setting the EOR marker. > > Still no push flag is explicitly set at the end of previous GSO > packet, making the aggregation on the receiver side sub-optimal - > and packetdrill self-tests less predictable. > > Explicitly mark the end of not contiguous DSS with the push flag. > > Fixes: 6d0060f600ad ("mptcp: Write MPTCP DSS headers to outgoing data packets") > Signed-off-by: Paolo Abeni <pabeni@redhat.com> > --- As long as I'm asking for other changes that require a v3 spin, please also change this commit title to "push at..." Thanks! Mat > net/mptcp/protocol.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/net/mptcp/protocol.c b/net/mptcp/protocol.c > index 3017b01ac488..21b3729c65ac 100644 > --- a/net/mptcp/protocol.c > +++ b/net/mptcp/protocol.c > @@ -1265,6 +1265,7 @@ static int mptcp_sendmsg_frag(struct sock *sk, struct sock *ssk, > mpext = mptcp_get_ext(skb); > if (!mptcp_skb_can_collapse_to(data_seq, skb, mpext)) { > TCP_SKB_CB(skb)->eor = 1; > + tcp_mark_push(tcp_sk(ssk), skb); > goto alloc_skb; > } > > -- > 2.43.0 > > >
diff --git a/net/mptcp/protocol.c b/net/mptcp/protocol.c index 3017b01ac488..21b3729c65ac 100644 --- a/net/mptcp/protocol.c +++ b/net/mptcp/protocol.c @@ -1265,6 +1265,7 @@ static int mptcp_sendmsg_frag(struct sock *sk, struct sock *ssk, mpext = mptcp_get_ext(skb); if (!mptcp_skb_can_collapse_to(data_seq, skb, mpext)) { TCP_SKB_CB(skb)->eor = 1; + tcp_mark_push(tcp_sk(ssk), skb); goto alloc_skb; }
when inserting not contiguous data in the subflow write queue, the protocol creates a new skb and prevent the TCP stack from merging it later with already queued skbs by setting the EOR marker. Still no push flag is explicitly set at the end of previous GSO packet, making the aggregation on the receiver side sub-optimal - and packetdrill self-tests less predictable. Explicitly mark the end of not contiguous DSS with the push flag. Fixes: 6d0060f600ad ("mptcp: Write MPTCP DSS headers to outgoing data packets") Signed-off-by: Paolo Abeni <pabeni@redhat.com> --- net/mptcp/protocol.c | 1 + 1 file changed, 1 insertion(+)