diff mbox series

[mptcp-next,v4,1/9] Squash to "mptcp: pm: add get_local_id() interface"

Message ID 7fe68131f39121b2265856a91429f072332eb642.1742804266.git.tanggeliang@kylinos.cn (mailing list archive)
State Accepted, archived
Commit d9ff94b6854e5b595869d89710b409284a3f31f8
Delegated to: Matthieu Baerts
Headers show
Series BPF path manager, part 6 | expand

Checks

Context Check Description
matttbe/checkpatch success total: 0 errors, 0 warnings, 0 checks, 7 lines checked
matttbe/shellcheck success MPTCP selftests files have not been modified
matttbe/build success Build and static analysis OK
matttbe/KVM_Validation__normal success Success! ✅
matttbe/KVM_Validation__debug success Success! ✅
matttbe/KVM_Validation__btf-normal__only_bpftest_all_ success Success! ✅
matttbe/KVM_Validation__btf-debug__only_bpftest_all_ success Success! ✅

Commit Message

Geliang Tang March 24, 2025, 8:19 a.m. UTC 
From: Geliang Tang <tanggeliang@kylinos.cn>

Add /* required */ comment for get_local_id and get_priority.

Signed-off-by: Geliang Tang <tanggeliang@kylinos.cn>
---
 include/net/mptcp.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Matthieu Baerts March 24, 2025, 9:27 a.m. UTC | #1 
Hi Geliang,

On 24/03/2025 09:19, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
> 
> Add /* required */ comment for get_local_id and get_priority.

Thank you for this patch. I just applied it not to have to carry this
simple Squash-to patch again. I will continue the review of the other
patches later.

New patches for t/upstream:
- d9ff94b6854e: Squash to "mptcp: pm: add get_local_id() interface"
- Results: 72b4c5fecd91..38f8291cd31d (export)

Tests are now in progress:

- export:
https://github.com/multipath-tcp/mptcp_net-next/commit/148e4f30be3b3ca9fcb647cc656ebf736925ee5d/checks

Cheers,
Matt
diff mbox series

Patch

diff --git a/include/net/mptcp.h b/include/net/mptcp.h
index 6a08ac862bbe..9f28ef550e10 100644
--- a/include/net/mptcp.h
+++ b/include/net/mptcp.h
@@ -118,6 +118,7 @@  struct mptcp_sched_ops {
 #define MPTCP_PM_BUF_MAX	(MPTCP_PM_NAME_MAX * MPTCP_PM_MAX)
 
 struct mptcp_pm_ops {
+	/* required */
 	int (*get_local_id)(struct mptcp_sock *msk,
 			    struct mptcp_pm_addr_entry *skc);
 	bool (*get_priority)(struct mptcp_sock *msk,