| Message ID | b2f6b47d2d9d23bf00211ed098c2f0d3227175cf.1684362296.git.geliang.tang@suse.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Commit | 4101020d41c3f268c54b416b7ee94bc418bb7764 |
| Delegated to: | Matthieu Baerts |
| Headers | show |
| Series | run sched tests in a dedicated ns | expand |
| Context | Check | Description |
|---|---|---|
| matttbe/KVM_Validation__normal__only_selftest_mptcp_join_ | success | Success! ✅ |
| matttbe/KVM_Validation__debug__except_selftest_mptcp_join_ | warning | Unstable: 4 failed test(s): packetdrill_fastopen packetdrill_mp_capable packetdrill_sockopts selftest_diag |
| matttbe/KVM_Validation__debug__only_selftest_mptcp_join_ | success | Success! ✅ |
| matttbe/build | success | Build and static analysis OK |
| matttbe/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 26 lines checked |
| matttbe/KVM_Validation__normal__except_selftest_mptcp_join_ | warning | Unstable: 1 failed test(s): packetdrill_fastopen |
Hi Geliang, Thank you for your modifications, that's great! Our CI did some validations and here is its report: - KVM Validation: normal (except selftest_mptcp_join): - Success! ✅: - Task: https://cirrus-ci.com/task/5629867937497088 - Summary: https://api.cirrus-ci.com/v1/artifact/task/5629867937497088/summary/summary.txt - KVM Validation: normal (only selftest_mptcp_join): - Success! ✅: - Task: https://cirrus-ci.com/task/5066917984075776 - Summary: https://api.cirrus-ci.com/v1/artifact/task/5066917984075776/summary/summary.txt - KVM Validation: debug (except selftest_mptcp_join): - Unstable: 4 failed test(s): packetdrill_fastopen packetdrill_mp_capable packetdrill_sockopts selftest_diag
Hi Geliang, Thank you for your modifications, that's great! Our CI did some validations and here is its report: - KVM Validation: normal (except selftest_mptcp_join): - Unstable: 1 failed test(s): packetdrill_fastopen
diff --git a/tools/testing/selftests/bpf/prog_tests/mptcp.c b/tools/testing/selftests/bpf/prog_tests/mptcp.c index 13594084d095..a968641cc94a 100644 --- a/tools/testing/selftests/bpf/prog_tests/mptcp.c +++ b/tools/testing/selftests/bpf/prog_tests/mptcp.c @@ -424,6 +424,7 @@ static void test_red(void) { struct mptcp_bpf_red *red_skel; int server_fd, client_fd; + struct nstoken *nstoken; struct bpf_link *link; red_skel = mptcp_bpf_red__open_and_load(); @@ -436,7 +437,9 @@ static void test_red(void) return; } - sched_init("subflow", "bpf_red"); + nstoken = sched_init("subflow", "bpf_red"); + if (!ASSERT_OK_PTR(nstoken, "sched_init:bpf_red")) + goto fail; server_fd = start_mptcp_server(AF_INET, ADDR_1, 0, 0); client_fd = connect_to_fd(server_fd, 0); @@ -446,7 +449,8 @@ static void test_red(void) close(client_fd); close(server_fd); - sched_cleanup(); +fail: + cleanup_netns(nstoken); bpf_link__destroy(link); mptcp_bpf_red__destroy(red_skel); }
Run mptcp sched test in a dedicated netns. Signed-off-by: Geliang Tang <geliang.tang@suse.com> --- tools/testing/selftests/bpf/prog_tests/mptcp.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)