| Message ID | bc0bb04ee334a2a38c7e5603405c16d6af4fff5f.1667897099.git.geliang.tang@suse.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | BPF redundant scheduler | expand |
| Context | Check | Description |
|---|---|---|
| matttbe/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 29 lines checked |
| matttbe/build | success | Build and static analysis OK |
| matttbe/KVM_Validation__normal | success | Success! ✅ |
| matttbe/KVM_Validation__debug | fail | Critical: 2 Call Trace(s) ❌ |
On Tue, 8 Nov 2022, Geliang Tang wrote: > Use new API. > > Signed-off-by: Geliang Tang <geliang.tang@suse.com> After patch 1 is updated, I think the series is looking good up to this patch. - Mat > --- > tools/testing/selftests/bpf/progs/mptcp_bpf_rr.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/bpf/progs/mptcp_bpf_rr.c b/tools/testing/selftests/bpf/progs/mptcp_bpf_rr.c > index ce4e98f83e43..e101428e5906 100644 > --- a/tools/testing/selftests/bpf/progs/mptcp_bpf_rr.c > +++ b/tools/testing/selftests/bpf/progs/mptcp_bpf_rr.c > @@ -16,8 +16,14 @@ void BPF_PROG(mptcp_sched_rr_release, const struct mptcp_sock *msk) > { > } > > -void BPF_STRUCT_OPS(bpf_rr_get_subflow, const struct mptcp_sock *msk, > +void BPF_STRUCT_OPS(bpf_rr_data_init, const struct mptcp_sock *msk, > struct mptcp_sched_data *data) > +{ > + mptcp_sched_data_set_contexts(msk, data); > +} > + > +int BPF_STRUCT_OPS(bpf_rr_get_subflow, const struct mptcp_sock *msk, > + struct mptcp_sched_data *data) > { > int nr = 0; > > @@ -35,12 +41,14 @@ void BPF_STRUCT_OPS(bpf_rr_get_subflow, const struct mptcp_sock *msk, > } > > mptcp_subflow_set_scheduled(data->contexts[nr], true); > + return 0; > } > > SEC(".struct_ops") > struct mptcp_sched_ops rr = { > .init = (void *)mptcp_sched_rr_init, > .release = (void *)mptcp_sched_rr_release, > + .data_init = (void *)bpf_rr_data_init, > .get_subflow = (void *)bpf_rr_get_subflow, > .name = "bpf_rr", > }; > -- > 2.35.3 > > > -- Mat Martineau Intel
diff --git a/tools/testing/selftests/bpf/progs/mptcp_bpf_rr.c b/tools/testing/selftests/bpf/progs/mptcp_bpf_rr.c index ce4e98f83e43..e101428e5906 100644 --- a/tools/testing/selftests/bpf/progs/mptcp_bpf_rr.c +++ b/tools/testing/selftests/bpf/progs/mptcp_bpf_rr.c @@ -16,8 +16,14 @@ void BPF_PROG(mptcp_sched_rr_release, const struct mptcp_sock *msk) { } -void BPF_STRUCT_OPS(bpf_rr_get_subflow, const struct mptcp_sock *msk, +void BPF_STRUCT_OPS(bpf_rr_data_init, const struct mptcp_sock *msk, struct mptcp_sched_data *data) +{ + mptcp_sched_data_set_contexts(msk, data); +} + +int BPF_STRUCT_OPS(bpf_rr_get_subflow, const struct mptcp_sock *msk, + struct mptcp_sched_data *data) { int nr = 0; @@ -35,12 +41,14 @@ void BPF_STRUCT_OPS(bpf_rr_get_subflow, const struct mptcp_sock *msk, } mptcp_subflow_set_scheduled(data->contexts[nr], true); + return 0; } SEC(".struct_ops") struct mptcp_sched_ops rr = { .init = (void *)mptcp_sched_rr_init, .release = (void *)mptcp_sched_rr_release, + .data_init = (void *)bpf_rr_data_init, .get_subflow = (void *)bpf_rr_get_subflow, .name = "bpf_rr", };
Use new API. Signed-off-by: Geliang Tang <geliang.tang@suse.com> --- tools/testing/selftests/bpf/progs/mptcp_bpf_rr.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)