| Message ID | 160416890683.710453.7723265174628409401.stgit@localhost.localdomain (mailing list archive) |
|---|---|
| Headers | show |
| Series | selftests/bpf: Migrate test_tcpbpf_user to be a part of test_progs framework | expand |
On Sat, Oct 31, 2020 at 11:31 AM Alexander Duyck <alexander.duyck@gmail.com> wrote: > > Move the test functionality from test_tcpbpf_user into the test_progs > framework so that it will be run any time the test_progs framework is run. > This will help to prevent future test escapes as the individual tests, such > as test_tcpbpf_user, are less likely to be run by developers and CI > tests. > > As a part of moving it over the series goes through and updates the code to > make use of the existing APIs included in the test_progs framework. This is > meant to simplify and streamline the test code and avoid duplication of > effort. > > v2: Dropped test_tcpbpf_user from .gitignore > Replaced CHECK_FAIL calls with CHECK calls > Minimized changes in patch 1 when moving the file > Updated stg mail command line to display renames in submission > Added shutdown logic to end of run_test function to guarantee close > Added patch that replaces the two maps with use of global variables > > --- > > Alexander Duyck (5): > selftests/bpf: Move test_tcppbf_user into test_progs > selftests/bpf: Drop python client/server in favor of threads > selftests/bpf: Replace EXPECT_EQ with ASSERT_EQ and refactor verify_results > selftests/bpf: Migrate tcpbpf_user.c to use BPF skeleton > selftest/bpf: Use global variables instead of maps for test_tcpbpf_kern > > > .../selftests/bpf/prog_tests/tcpbpf_user.c | 239 +++++++++--------- > .../selftests/bpf/progs/test_tcpbpf_kern.c | 86 +------ > tools/testing/selftests/bpf/tcp_client.py | 50 ---- > tools/testing/selftests/bpf/tcp_server.py | 80 ------ > tools/testing/selftests/bpf/test_tcpbpf.h | 2 + > 5 files changed, 135 insertions(+), 322 deletions(-) > delete mode 100755 tools/testing/selftests/bpf/tcp_client.py > delete mode 100755 tools/testing/selftests/bpf/tcp_server.py > > -- It looks like the "--to" on the cover page was dropped and it wasn't delivered to the bpf mailing list. So I am just going to reply to the one that was delivered to netdev so that it is visible for the people on the bpf list. Thanks. - Alex
Move the test functionality from test_tcpbpf_user into the test_progs framework so that it will be run any time the test_progs framework is run. This will help to prevent future test escapes as the individual tests, such as test_tcpbpf_user, are less likely to be run by developers and CI tests. As a part of moving it over the series goes through and updates the code to make use of the existing APIs included in the test_progs framework. This is meant to simplify and streamline the test code and avoid duplication of effort. v2: Dropped test_tcpbpf_user from .gitignore Replaced CHECK_FAIL calls with CHECK calls Minimized changes in patch 1 when moving the file Updated stg mail command line to display renames in submission Added shutdown logic to end of run_test function to guarantee close Added patch that replaces the two maps with use of global variables --- Alexander Duyck (5): selftests/bpf: Move test_tcppbf_user into test_progs selftests/bpf: Drop python client/server in favor of threads selftests/bpf: Replace EXPECT_EQ with ASSERT_EQ and refactor verify_results selftests/bpf: Migrate tcpbpf_user.c to use BPF skeleton selftest/bpf: Use global variables instead of maps for test_tcpbpf_kern .../selftests/bpf/prog_tests/tcpbpf_user.c | 239 +++++++++--------- .../selftests/bpf/progs/test_tcpbpf_kern.c | 86 +------ tools/testing/selftests/bpf/tcp_client.py | 50 ---- tools/testing/selftests/bpf/tcp_server.py | 80 ------ tools/testing/selftests/bpf/test_tcpbpf.h | 2 + 5 files changed, 135 insertions(+), 322 deletions(-) delete mode 100755 tools/testing/selftests/bpf/tcp_client.py delete mode 100755 tools/testing/selftests/bpf/tcp_server.py --