mbox series

[net-next,v3,0/5] Add MBIM over MHI support

Message ID 1612462661-23045-1-git-send-email-loic.poulain@linaro.org (mailing list archive)
Headers show
Series Add MBIM over MHI support | expand

Message

Loic Poulain Feb. 4, 2021, 6:17 p.m. UTC 
This patch adds MBIM decoding/encoding support to mhi-net, using
mhi-net rx and tx_fixup 'proto' callbacks introduced in the series.

v2:
   - net.c: mhi_net_dev as rx/tx_fixup parameter
   - mbim: Check nth size/sequence in nth16_verify
   - mbim: Add netif_dbg message for verbose error
   - mbim: Add inline comment for MHI MBIM limitation (no DSS)
   - mbim: Fix copyright issue
   - mbim: Reword commit message

v3:
   - net: dedicated commit for mhi.h
   - net: add rx_length_errors stat change
   - net: rename rx_fixup to rx
   - net: proto rx returns void
   - mbim: remove all unecessary parenthesis
   - mbim: report errors and rx_length_errors
   - mbim: rate_limited errors in rx/tx path 
   - mbim: create define for NDP signature mask
   - mbim: switch-case to if for signature check
   - mbim: skb_cow_head() to fix headroom if necessary

Loic Poulain (5):
  net: mhi: Add protocol support
  net: mhi: Add dedicated folder
  net: mhi: Create mhi.h
  net: mhi: Add rx_length_errors stat
  net: mhi: Add mbim proto

 drivers/net/Makefile         |   2 +-
 drivers/net/mhi/Makefile     |   3 +
 drivers/net/mhi/mhi.h        |  40 +++++
 drivers/net/mhi/net.c        | 408 +++++++++++++++++++++++++++++++++++++++++++
 drivers/net/mhi/proto_mbim.c | 294 +++++++++++++++++++++++++++++++
 drivers/net/mhi_net.c        | 384 ----------------------------------------
 6 files changed, 746 insertions(+), 385 deletions(-)
 create mode 100644 drivers/net/mhi/Makefile
 create mode 100644 drivers/net/mhi/mhi.h
 create mode 100644 drivers/net/mhi/net.c
 create mode 100644 drivers/net/mhi/proto_mbim.c
 delete mode 100644 drivers/net/mhi_net.c

Comments

Jakub Kicinski Feb. 4, 2021, 8:37 p.m. UTC | #1 
On Thu, 4 Feb 2021 19:21:23 +0100 Loic Poulain wrote:
> On Thu, 4 Feb 2021 at 19:09, Loic Poulain <loic.poulain@linaro.org> wrote:
> >
> > This patch adds MBIM decoding/encoding support to mhi-net, using
> > mhi-net rx and tx_fixup 'proto' callbacks introduced in the series.  
> 
> This series has been rebased on top of the recently submitted:
>     [PATCH net-next v5 1/2] net: mhi-net: Add re-aggregation of
> fragmented packets
> Since I assumed it would be merged first, but let me know if it's not fine.

We can leave this as is for review, but patchwork does not understand
dependencies, so this couldn't get build-checked:

https://patchwork.kernel.org/project/netdevbpf/list/?series=428171&state=*

You'll need to repost once the other set is merged. In the future
best to send the dependent series as [RFC net-next] to make it clear 
you're aware repost will be needed.