| Message ID | 162318053542.323820.3719766457956848570.stgit@john-XPS-13-9370 (mailing list archive) |
|---|---|
| Headers | show |
| Series | bpf fix for mixed tail calls and subprograms | expand |
On 6/8/21 12:29 PM, John Fastabend wrote: > We recently tried to use mixed programs that have both tail calls and > subprograms, but it needs the attached fix. Also added a small test > addition that will cause the failure without the fix. > > Thanks, > John > > --- > > John Fastabend (2): > bpf: Fix null ptr deref with mixed tail calls and subprogs > bpf: selftest to verify mixing bpf2bpf calls and tailcalls with insn patch > > > .../selftests/bpf/progs/tailcall_bpf2bpf4.c | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) Don't know what happens. Apparently, the first patch made changes in kernel/bpf/verifier.c, but it didn't show up in the above. > > -- >
Yonghong Song wrote: > > > On 6/8/21 12:29 PM, John Fastabend wrote: > > We recently tried to use mixed programs that have both tail calls and > > subprograms, but it needs the attached fix. Also added a small test > > addition that will cause the failure without the fix. > > > > Thanks, > > John > > > > --- > > > > John Fastabend (2): > > bpf: Fix null ptr deref with mixed tail calls and subprogs > > bpf: selftest to verify mixing bpf2bpf calls and tailcalls with insn patch > > > > > > .../selftests/bpf/progs/tailcall_bpf2bpf4.c | 17 +++++++++++++++++ > > 1 file changed, 17 insertions(+) > > Don't know what happens. Apparently, the first patch made changes > in kernel/bpf/verifier.c, but it didn't show up in the above. Agh its how I applied the patches and cover-letter :/ I moved them between trees (bpf-next -> bpf) and lost the diff. I can resubmit if anyone cares.
On 6/9/21 9:17 AM, John Fastabend wrote: > Yonghong Song wrote: >> >> >> On 6/8/21 12:29 PM, John Fastabend wrote: >>> We recently tried to use mixed programs that have both tail calls and >>> subprograms, but it needs the attached fix. Also added a small test >>> addition that will cause the failure without the fix. >>> >>> Thanks, >>> John >>> >>> --- >>> >>> John Fastabend (2): >>> bpf: Fix null ptr deref with mixed tail calls and subprogs >>> bpf: selftest to verify mixing bpf2bpf calls and tailcalls with insn patch >>> >>> >>> .../selftests/bpf/progs/tailcall_bpf2bpf4.c | 17 +++++++++++++++++ >>> 1 file changed, 17 insertions(+) >> >> Don't know what happens. Apparently, the first patch made changes >> in kernel/bpf/verifier.c, but it didn't show up in the above. > > Agh its how I applied the patches and cover-letter :/ I moved them between > trees (bpf-next -> bpf) and lost the diff. I can resubmit if anyone > cares. You don't need to resubmit just because of this. This cover letter may not be merged eventually.
We recently tried to use mixed programs that have both tail calls and subprograms, but it needs the attached fix. Also added a small test addition that will cause the failure without the fix. Thanks, John --- John Fastabend (2): bpf: Fix null ptr deref with mixed tail calls and subprogs bpf: selftest to verify mixing bpf2bpf calls and tailcalls with insn patch .../selftests/bpf/progs/tailcall_bpf2bpf4.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) --