[net-next,0/9] bnxt_en: Updates.

Message

Michael Chan March 5, 2022, 8:54 a.m. UTC

This patch series contains mainly NVRAM related features.  More
NVRAM error checking and logging are added when installing firmware
packages.  A new devlink hw health report is now added to report
and diagnose NVRAM issues.  Other miscellaneous patches include
reporting correctly cards that don't support link pause, adding
an internal unknown link state, and avoiding unnecessary link
toggle during firmware reset.

Edwin Peer (2):
  bnxt_en: introduce initial link state of unknown
  bnxt_en: Do not destroy health reporters during reset

Kalesh AP (4):
  bnxt_en: refactor error handling of HWRM_NVM_INSTALL_UPDATE
  bnxt_en: add more error checks to HWRM_NVM_INSTALL_UPDATE
  bnxt_en: parse result field when NVRAM package install fails
  bnxt_en: implement hw health reporter

Michael Chan (2):
  bnxt_en: Properly report no pause support on some cards
  bnxt_en: Eliminate unintended link toggle during FW reset

Vikas Gupta (1):
  bnxt_en: add an nvm test for hw diagnose

 drivers/net/ethernet/broadcom/bnxt/bnxt.c     |  61 ++++--
 drivers/net/ethernet/broadcom/bnxt/bnxt.h     |  57 +++++-
 drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.c |   3 +-
 .../net/ethernet/broadcom/bnxt/bnxt_devlink.c | 191 ++++++++++++++++--
 .../net/ethernet/broadcom/bnxt/bnxt_devlink.h |   3 +-
 .../net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 119 ++++++++---
 .../net/ethernet/broadcom/bnxt/bnxt_ethtool.h |   7 +
 7 files changed, 367 insertions(+), 74 deletions(-)

Comments

[e-mail] March 5, 2022, 11:20 a.m. UTC | #1

Hello:

This series was applied to netdev/net-next.git (master)
by David S. Miller <[e-mail]>:

On Sat,  5 Mar 2022 03:54:33 -0500 you wrote:
> This patch series contains mainly NVRAM related features.  More
> NVRAM error checking and logging are added when installing firmware
> packages.  A new devlink hw health report is now added to report
> and diagnose NVRAM issues.  Other miscellaneous patches include
> reporting correctly cards that don't support link pause, adding
> an internal unknown link state, and avoiding unnecessary link
> toggle during firmware reset.
> 
> [...]

Here is the summary with links:
  - [net-next,1/9] bnxt_en: refactor error handling of HWRM_NVM_INSTALL_UPDATE
    https://git.kernel.org/netdev/net-next/c/8e42aef0b730
  - [net-next,2/9] bnxt_en: add more error checks to HWRM_NVM_INSTALL_UPDATE
    https://git.kernel.org/netdev/net-next/c/54ff1e3e8fc3
  - [net-next,3/9] bnxt_en: parse result field when NVRAM package install fails
    https://git.kernel.org/netdev/net-next/c/02acd399533e
  - [net-next,4/9] bnxt_en: introduce initial link state of unknown
    https://git.kernel.org/netdev/net-next/c/0f5a4841f2ec
  - [net-next,5/9] bnxt_en: Properly report no pause support on some cards
    https://git.kernel.org/netdev/net-next/c/9a3bc77ec65e
  - [net-next,6/9] bnxt_en: Eliminate unintended link toggle during FW reset
    https://git.kernel.org/netdev/net-next/c/7c492a2530c1
  - [net-next,7/9] bnxt_en: Do not destroy health reporters during reset
    https://git.kernel.org/netdev/net-next/c/f16a91692866
  - [net-next,8/9] bnxt_en: implement hw health reporter
    https://git.kernel.org/netdev/net-next/c/bafed3f231f7
  - [net-next,9/9] bnxt_en: add an nvm test for hw diagnose
    https://git.kernel.org/netdev/net-next/c/22f5dba5065d

You are awesome, thank you!

Jakub Kicinski March 7, 2022, 10:27 p.m. UTC | #2

On Sat,  5 Mar 2022 03:54:33 -0500 Michael Chan wrote:
> This patch series contains mainly NVRAM related features.  More
> NVRAM error checking and logging are added when installing firmware
> packages.  A new devlink hw health report is now added to report
> and diagnose NVRAM issues.  Other miscellaneous patches include
> reporting correctly cards that don't support link pause, adding
> an internal unknown link state, and avoiding unnecessary link
> toggle during firmware reset.

The devlink parts are missing documentation, I'm not sure how it's
supposed to operate and AFAICT it's not just a normal health reporter
implementation.

Please stop posting patches during the weekend.

Michael Chan March 7, 2022, 11:56 p.m. UTC | #3

On Mon, Mar 7, 2022 at 2:27 PM Jakub Kicinski <[e-mail]> wrote:
>
> On Sat,  5 Mar 2022 03:54:33 -0500 Michael Chan wrote:
> > This patch series contains mainly NVRAM related features.  More
> > NVRAM error checking and logging are added when installing firmware
> > packages.  A new devlink hw health report is now added to report
> > and diagnose NVRAM issues.  Other miscellaneous patches include
> > reporting correctly cards that don't support link pause, adding
> > an internal unknown link state, and avoiding unnecessary link
> > toggle during firmware reset.
>
> The devlink parts are missing documentation, I'm not sure how it's
> supposed to operate and AFAICT it's not just a normal health reporter
> implementation.

Sorry, missed the documentation update.  My colleagues will respond to
your other comments and we will add the documentation.

>
> Please stop posting patches during the weekend.

This is the first time I'm hearing that patches cannot be posted
during the weekend.