mbox series

[v2,bpf-next,0/3] libbpf: uprobe name-based attach followups

Message ID 1649245431-29956-1-git-send-email-alan.maguire@oracle.com (mailing list archive)
Headers show
Series libbpf: uprobe name-based attach followups | expand

Message

Alan Maguire April 6, 2022, 11:43 a.m. UTC 
Follow-up series to [1] to address some suggestions from Andrii to
improve parsing and make it more robust (patches 1, 2) and to improve
validation of u[ret]probe firing by validating expected argument
and return values (patch 3).

[1] https://lore.kernel.org/bpf/164903521182.13106.12656654142629368774.git-patchwork-notify@kernel.org/

Changes since v1:
- split library name, auto-attach parsing into separate patches (Andrii, patches 1, 2)
- made str_has_sfx() static inline, avoided repeated strlen()s by storing lengths,
  used strlen() instead of strnlen() (Andrii, patch 1)
- fixed sscanf() arg to use %li, switched logging to use "prog '%s'" format,
  used direct strcmp() on probe_type instead of prefix check (Andrii, patch 2)
- switched auto-attach tests to log parameter/return values to be checked by
  user-space side of tests. Needed to add pid filtering to avoid capturing
  stray malloc()s (Andrii, patch 3) 

Alan Maguire (3):
  libbpf: improve library identification for uprobe binary path
    resolution
  libbpf: improve string parsing for uprobe auto-attach
  selftests/bpf: uprobe tests should verify param/return values

 tools/lib/bpf/libbpf.c                             | 85 +++++++++-------------
 tools/lib/bpf/libbpf_internal.h                    | 11 +++
 .../selftests/bpf/prog_tests/uprobe_autoattach.c   | 25 +++++--
 .../selftests/bpf/progs/test_uprobe_autoattach.c   | 43 ++++++++---
 4 files changed, 96 insertions(+), 68 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org April 7, 2022, 6:50 p.m. UTC | #1 
Hello:

This series was applied to bpf/bpf-next.git (master)
by Andrii Nakryiko <andrii@kernel.org>:

On Wed,  6 Apr 2022 12:43:48 +0100 you wrote:
> Follow-up series to [1] to address some suggestions from Andrii to
> improve parsing and make it more robust (patches 1, 2) and to improve
> validation of u[ret]probe firing by validating expected argument
> and return values (patch 3).
> 
> [1] https://lore.kernel.org/bpf/164903521182.13106.12656654142629368774.git-patchwork-notify@kernel.org/
> 
> [...]

Here is the summary with links:
  - [v2,bpf-next,1/3] libbpf: improve library identification for uprobe binary path resolution
    https://git.kernel.org/bpf/bpf-next/c/a1c9d61b19cb
  - [v2,bpf-next,2/3] libbpf: improve string parsing for uprobe auto-attach
    https://git.kernel.org/bpf/bpf-next/c/90db26e6be01
  - [v2,bpf-next,3/3] selftests/bpf: uprobe tests should verify param/return values
    https://git.kernel.org/bpf/bpf-next/c/1717e248014c

You are awesome, thank you!