[net-next,00/10] devlink: cleanups and move devlink health functionality to separate file

Message

Moshe Shemesh Feb. 13, 2023, 1:14 p.m. UTC

This patchset moves devlink health callbacks, helpers and related code
from leftover.c to new file health.c. About 1.3K LoC are moved by this
patchset, covering all devlink health functionality.

In addition this patchset includes a couple of small cleanups in devlink
health code and documentation update.

Moshe Shemesh (10):
  devlink: Split out health reporter create code
  devlink: health: Fix nla_nest_end in error flow
  devlink: Move devlink health get and set code to health file
  devlink: health: Don't try to add trace with NULL msg
  devlink: Move devlink health report and recover to health file
  devlink: Move devlink fmsg and health diagnose to health file
  devlink: Move devlink health dump to health file
  devlink: Move devlink health test to health file
  devlink: Move health common function to health file
  devlink: Update devlink health documentation

 .../networking/devlink/devlink-health.rst     |   23 +-
 net/devlink/Makefile                          |    2 +-
 net/devlink/devl_internal.h                   |   16 +
 net/devlink/health.c                          | 1333 +++++++++++++++++
 net/devlink/leftover.c                        | 1330 +---------------
 5 files changed, 1373 insertions(+), 1331 deletions(-)
 create mode 100644 net/devlink/health.c

Comments

Jiri Pirko Feb. 13, 2023, 1:35 p.m. UTC | #1

Mon, Feb 13, 2023 at 02:14:08PM CET, [e-mail] wrote:
>This patchset moves devlink health callbacks, helpers and related code
>from leftover.c to new file health.c. About 1.3K LoC are moved by this
>patchset, covering all devlink health functionality.
>
>In addition this patchset includes a couple of small cleanups in devlink
>health code and documentation update.
>
>Moshe Shemesh (10):
>  devlink: Split out health reporter create code
>  devlink: health: Fix nla_nest_end in error flow
>  devlink: Move devlink health get and set code to health file
>  devlink: health: Don't try to add trace with NULL msg
>  devlink: Move devlink health report and recover to health file
>  devlink: Move devlink fmsg and health diagnose to health file
>  devlink: Move devlink health dump to health file
>  devlink: Move devlink health test to health file
>  devlink: Move health common function to health file
>  devlink: Update devlink health documentation

set-
Reviewed-by: Jiri Pirko <[e-mail]>

Thanks Moshe!

Jakub Kicinski Feb. 14, 2023, 6:23 a.m. UTC | #2

On Mon, 13 Feb 2023 15:14:08 +0200 Moshe Shemesh wrote:
> This patchset moves devlink health callbacks, helpers and related code
> from leftover.c to new file health.c. About 1.3K LoC are moved by this
> patchset, covering all devlink health functionality.
> 
> In addition this patchset includes a couple of small cleanups in devlink
> health code and documentation update.

Reviewed-by: Jakub Kicinski <[e-mail]>