[net-next,v4,0/9] net/smc: implement SMCv2.1 virtual ISM device support

Message

Wen Gu Dec. 7, 2023, 3:49 a.m. UTC

(Note that this patch set depends on an under-reviewing bugfix patch:
Link: https://lore.kernel.org/netdev/[e-mail]/)

The fourth edition of SMCv2 adds the SMC version 2.1 feature updates for
SMC-Dv2 with virtual ISM. Virtual ISM are created and supported mainly by
OS or hypervisor software, comparable to IBM ISM which is based on platform
firmware or hardware.

With the introduction of virtual ISM, SMCv2.1 makes some updates:

- Introduce feature bitmask to indicate supplemental features.
- Reserve a range of CHIDs for virtual ISM.
- Support extended GIDs (128 bits) in CLC handshake.

So this patch set aims to implement these updates in Linux kernel. And it
acts as the first part of SMC-D virtual ISM extension & loopback-ism [1].

[1] https://lore.kernel.org/netdev/[e-mail]/

v4->v3:
- Using SMCD_CLC_MAX_V2_GID_ENTRIES to indicate the max gid entries
  in CLC proposal and using SMC_MAX_V2_ISM_DEVS to indicate the max
  devices to propose;
- Using i and i+1 in smc_find_ism_v2_device_serv();
- Replacing the large if-else block in smc_clc_send_confirm_accept()
  with 2 subfunctions;
- Fixing missing byte order conversion of GID and token in CLC handshake,
  which is in a separate patch sending to net:
  https://lore.kernel.org/netdev/[e-mail]/
- Adding extended GID in SMC-D lgr netlink attribute;

v3->v2:
- Rename smc_clc_fill_fce as smc_clc_fill_fce_v2x;
- Remove ISM_IDENT_MASK from drivers/s390/net/ism.h;
- Add explicitly assigning 'false' to ism_v2_capable in ism_dev_init();
- Remove smc_ism_set_v2_capable() helper for now, and introduce it in
  later loopback-ism implementation;

v2->v1:
- Fix sparse complaint;
- Rebase to the latest net-next;

Wen Gu (9):
  net/smc: Rename some 'fce' to 'fce_v2x' for clarity
  net/smc: introduce sub-functions for smc_clc_send_confirm_accept()
  net/smc: support SMCv2.x supplemental features negotiation
  net/smc: introduce virtual ISM device support feature
  net/smc: define a reserved CHID range for virtual ISM devices
  net/smc: compatible with 128-bits extend GID of virtual ISM device
  net/smc: disable SEID on non-s390 archs where virtual ISM may be used
  net/smc: manage system EID in SMC stack instead of ISM driver
  net/smc: support extended GID in SMC-D lgr netlink attribute

 drivers/s390/net/ism.h        |   7 --
 drivers/s390/net/ism_drv.c    |  57 +++------
 include/linux/ism.h           |   1 -
 include/net/smc.h             |  16 ++-
 include/uapi/linux/smc.h      |   2 +
 include/uapi/linux/smc_diag.h |   2 +
 net/smc/af_smc.c              |  68 +++++++++--
 net/smc/smc.h                 |  10 +-
 net/smc/smc_clc.c             | 278 +++++++++++++++++++++++++++---------------
 net/smc/smc_clc.h             |  27 ++--
 net/smc/smc_core.c            |  37 ++++--
 net/smc/smc_core.h            |  18 ++-
 net/smc/smc_diag.c            |   9 +-
 net/smc/smc_ism.c             |  50 +++++---
 net/smc/smc_ism.h             |  30 ++++-
 net/smc/smc_pnet.c            |   4 +-
 16 files changed, 403 insertions(+), 213 deletions(-)

Comments

Jakub Kicinski Dec. 8, 2023, 12:49 a.m. UTC | #1

On Thu,  7 Dec 2023 11:49:45 +0800 Wen Gu wrote:
> (Note that this patch set depends on an under-reviewing bugfix patch:
> Link: https://lore.kernel.org/netdev/[e-mail]/)

Post as an RFC, please, until the dependencies have converged.

Wen Gu Dec. 8, 2023, 3:30 a.m. UTC | #2

On 2023/12/8 08:49, Jakub Kicinski wrote:
> On Thu,  7 Dec 2023 11:49:45 +0800 Wen Gu wrote:
>> (Note that this patch set depends on an under-reviewing bugfix patch:
>> Link: https://lore.kernel.org/netdev/[e-mail]/)
> 
> Post as an RFC, please, until the dependencies have converged.

Understand, thank you.

And I found that the dependency fix has been converged. This patch set will be reposted as a v5.