[RFC,0/2] net: provides dim profile fine-tuning channels

Message

Heng Qi March 14, 2024, 1:09 p.m. UTC

The NetDIM library provides excellent acceleration for many modern
network cards. However, the default profiles of DIM limits its maximum
capabilities for different NICs, so providing a channel through which
the NIC can be custom configured is necessary.

Please review, thank you very much!

Heng Qi (2):
  net: add sysfs attributes for customized dim profile management
  virtio-net: support net sysfs to fine-tune dim profile

 Documentation/ABI/testing/sysfs-class-net |  17 +++
 drivers/net/virtio_net.c                  |  64 ++++++++++-
 include/linux/dim.h                       |   7 ++
 include/linux/netdevice.h                 |  35 ++++++
 lib/dim/net_dim.c                         |   6 --
 net/core/net-sysfs.c                      | 172 ++++++++++++++++++++++++++++++
 6 files changed, 294 insertions(+), 7 deletions(-)

Comments

Jakub Kicinski March 14, 2024, 6:49 p.m. UTC | #1

On Thu, 14 Mar 2024 21:09:31 +0800 Heng Qi wrote:
> The NetDIM library provides excellent acceleration for many modern
> network cards. However, the default profiles of DIM limits its maximum
> capabilities for different NICs, so providing a channel through which
> the NIC can be custom configured is necessary.

Given that DIM is currently enabled and disable via ethtool
why are you putting the API is sysfs and ops in ndo?

Heng Qi March 15, 2024, 2:32 a.m. UTC | #2

在 2024/3/15 上午2:49, Jakub Kicinski 写道:
> On Thu, 14 Mar 2024 21:09:31 +0800 Heng Qi wrote:
>> The NetDIM library provides excellent acceleration for many modern
>> network cards. However, the default profiles of DIM limits its maximum
>> capabilities for different NICs, so providing a channel through which
>> the NIC can be custom configured is necessary.
> Given that DIM is currently enabled and disable via ethtool
> why are you putting the API is sysfs and ops in ndo?

Hi Jakub,

Thank you for reaching out. We're flexible regarding configuration 
methods and are
open to using either sysfs or ethtool, depending on what's most 
appropriate for the task at hand.

If the ethtool is favored, I am happy to proceed with it!

Best regards,
Heng