mbox series

[v5.10,0/2] Fix for CVE-2024-36901

Message ID 1720520570-9904-1-git-send-email-ashwin.kamat@broadcom.com (mailing list archive)
Headers show
Series Fix for CVE-2024-36901 | expand

Message

Ashwin Kamat July 9, 2024, 10:22 a.m. UTC 
From: Ashwin Dayanand Kamat <ashwin.kamat@broadcom.com>

net/ipv6: annotate data-races around cnf.disable_ipv6
       disable_ipv6 is read locklessly, add appropriate READ_ONCE() and WRITE_ONCE() annotations.

net/ipv6: prevent NULL dereference in ip6_output()
       Fix for CVE-2024-36901

Ashwin Dayanand Kamat (2):
       net/ipv6: annotate data-races around cnf.disable_ipv6
       net/ipv6: prevent NULL dereference in ip6_output()

 net/ipv6/addrconf.c   | 9 +++++----
 net/ipv6/ip6_input.c  | 2 +-
 net/ipv6/ip6_output.c | 2 +-
 3 files changed, 7 insertions(+), 6 deletions(-)

--
2.7.4

Comments

Florian Fainelli July 12, 2024, 9:19 p.m. UTC | #1 
On 7/9/24 03:22, Ashwin Kamat wrote:
> From: Ashwin Dayanand Kamat <ashwin.kamat@broadcom.com>
> 
> net/ipv6: annotate data-races around cnf.disable_ipv6
>         disable_ipv6 is read locklessly, add appropriate READ_ONCE() and WRITE_ONCE() annotations.
> 
> net/ipv6: prevent NULL dereference in ip6_output()
>         Fix for CVE-2024-36901
> 
> Ashwin Dayanand Kamat (2):
>         net/ipv6: annotate data-races around cnf.disable_ipv6
>         net/ipv6: prevent NULL dereference in ip6_output()

LGTM

> 
>   net/ipv6/addrconf.c   | 9 +++++----
>   net/ipv6/ip6_input.c  | 2 +-
>   net/ipv6/ip6_output.c | 2 +-
>   3 files changed, 7 insertions(+), 6 deletions(-)
> 
> --
> 2.7.4
>
Greg KH July 13, 2024, 6:52 a.m. UTC | #2 
On Tue, Jul 09, 2024 at 03:52:48PM +0530, Ashwin Kamat wrote:
> From: Ashwin Dayanand Kamat <ashwin.kamat@broadcom.com>
> 
> net/ipv6: annotate data-races around cnf.disable_ipv6
>        disable_ipv6 is read locklessly, add appropriate READ_ONCE() and WRITE_ONCE() annotations.
> 
> net/ipv6: prevent NULL dereference in ip6_output()
>        Fix for CVE-2024-36901
> 
> Ashwin Dayanand Kamat (2):
>        net/ipv6: annotate data-races around cnf.disable_ipv6
>        net/ipv6: prevent NULL dereference in ip6_output()
> 
>  net/ipv6/addrconf.c   | 9 +++++----
>  net/ipv6/ip6_input.c  | 2 +-
>  net/ipv6/ip6_output.c | 2 +-
>  3 files changed, 7 insertions(+), 6 deletions(-)
> 
> --
> 2.7.4
> 

Any reason you didn't actually cc: the stable@vger.kernel.org address
for these so we know to pick them up?

thanks,

greg k-h
Greg KH July 13, 2024, 11:05 a.m. UTC | #3 
On Sat, Jul 13, 2024 at 03:16:15PM +0530, Ashwin Kamat wrote:
> Hi Greg,
> The patches get applied to 5.10 stable branch with an offset [i.e Hunk #1
> succeeded at 240 (offset 19 lines).]
> To avoid that I sent separate patches to 5.10 and 5.15. Apart from that
> there is no other difference.

That's not what I asked, I asked:

> > Any reason you didn't actually cc: the stable@vger.kernel.org address
> > for these so we know to pick them up?

That is a requirement to get a patch merged into a stable release,
right?

thanks,

greg k-h
Greg KH July 15, 2024, 11:47 a.m. UTC | #4 
On Fri, Jul 12, 2024 at 02:19:37PM -0700, Florian Fainelli wrote:
> On 7/9/24 03:22, Ashwin Kamat wrote:
> > From: Ashwin Dayanand Kamat <ashwin.kamat@broadcom.com>
> > 
> > net/ipv6: annotate data-races around cnf.disable_ipv6
> >         disable_ipv6 is read locklessly, add appropriate READ_ONCE() and WRITE_ONCE() annotations.
> > 
> > net/ipv6: prevent NULL dereference in ip6_output()
> >         Fix for CVE-2024-36901
> > 
> > Ashwin Dayanand Kamat (2):
> >         net/ipv6: annotate data-races around cnf.disable_ipv6
> >         net/ipv6: prevent NULL dereference in ip6_output()
> 
> LGTM

All now queued up, thanks.

greg k-h