[bpf-next,0/2] Do not limit cb_flags when creating child sk from listen sk

Message

Martin KaFai Lau Oct. 2, 2020, 1:34 a.m. UTC

This set fixes an issue that the bpf_skops_init_child() unnecessarily
limited the child sk from inheriting all bpf_sock_ops_cb_flags
of the listen sk.  It also adds a test to check that.

Martin KaFai Lau (2):
  bpf: tcp: Do not limit cb_flags when creating child sk from listen sk
  bpf: selftest: Ensure the child sk inherited all bpf_sock_ops_cb_flags

 include/net/tcp.h                             | 33 -------------------
 net/ipv4/tcp_minisocks.c                      |  1 -
 .../bpf/prog_tests/tcp_hdr_options.c          | 12 +++++++
 .../bpf/progs/test_misc_tcp_hdr_options.c     |  4 +--
 .../bpf/progs/test_tcp_hdr_options.c          |  7 ++--
 .../selftests/bpf/test_tcp_hdr_options.h      |  5 +--
 6 files changed, 22 insertions(+), 40 deletions(-)

Comments

Stanislav Fomichev Oct. 2, 2020, 4:03 p.m. UTC | #1

On 10/01, Martin KaFai Lau wrote:
> This set fixes an issue that the bpf_skops_init_child() unnecessarily
> limited the child sk from inheriting all bpf_sock_ops_cb_flags
> of the listen sk.  It also adds a test to check that.
Thank you, that fixed it for me!

Tested-by: Stanislav Fomichev <[e-mail]>

[e-mail] Oct. 2, 2020, 6:50 p.m. UTC | #2

Hello:

This series was applied to bpf/bpf-next.git (refs/heads/master):

On Thu, 1 Oct 2020 18:34:42 -0700 you wrote:
> This set fixes an issue that the bpf_skops_init_child() unnecessarily
> limited the child sk from inheriting all bpf_sock_ops_cb_flags
> of the listen sk.  It also adds a test to check that.
> 
> Martin KaFai Lau (2):
>   bpf: tcp: Do not limit cb_flags when creating child sk from listen sk
>   bpf: selftest: Ensure the child sk inherited all bpf_sock_ops_cb_flags
> 
> [...]

Here is the summary with links:
  - [bpf-next,1/2] bpf: tcp: Do not limit cb_flags when creating child sk from listen sk
    https://git.kernel.org/bpf/bpf-next/c/82f45c6c4a70
  - [bpf-next,2/2] bpf: selftest: Ensure the child sk inherited all bpf_sock_ops_cb_flags
    https://git.kernel.org/bpf/bpf-next/c/96d46c508506

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html