mbox series

[net,0/3] mlxsw: Various fixes

Message ID 20201024133733.2107509-1-idosch@idosch.org (mailing list archive)
Headers show
Series mlxsw: Various fixes | expand

Message

Ido Schimmel Oct. 24, 2020, 1:37 p.m. UTC
From: Ido Schimmel <idosch@nvidia.com>

This patch set contains various fixes for mlxsw.

Patch #1 ensures that only link modes that are supported by both the
device and the driver are advertised. When a link mode that is not
supported by the driver is negotiated by the device, it will be
presented as an unknown speed by ethtool, causing the bond driver to
wrongly assume that the link is down.

Patch #2 fixes a trivial memory leak upon module removal.

Patch #3 fixes a use-after-free that syzkaller was able to trigger once
on a slow emulator after a few months of fuzzing.

Amit Cohen (2):
  mlxsw: Only advertise link modes supported by both driver and device
  mlxsw: core: Fix use-after-free in mlxsw_emad_trans_finish()

Ido Schimmel (1):
  mlxsw: core: Fix memory leak on module removal

 drivers/net/ethernet/mellanox/mlxsw/core.c    |  5 ++++
 .../net/ethernet/mellanox/mlxsw/spectrum.c    |  9 ++++--
 .../net/ethernet/mellanox/mlxsw/spectrum.h    |  1 +
 .../mellanox/mlxsw/spectrum_ethtool.c         | 30 +++++++++++++++++++
 4 files changed, 43 insertions(+), 2 deletions(-)

Comments

Jakub Kicinski Oct. 26, 2020, 11:56 p.m. UTC | #1
On Sat, 24 Oct 2020 16:37:30 +0300 Ido Schimmel wrote:
> From: Ido Schimmel <idosch@nvidia.com>
> 
> This patch set contains various fixes for mlxsw.
> 
> Patch #1 ensures that only link modes that are supported by both the
> device and the driver are advertised. When a link mode that is not
> supported by the driver is negotiated by the device, it will be
> presented as an unknown speed by ethtool, causing the bond driver to
> wrongly assume that the link is down.
> 
> Patch #2 fixes a trivial memory leak upon module removal.
> 
> Patch #3 fixes a use-after-free that syzkaller was able to trigger once
> on a slow emulator after a few months of fuzzing.

Applied, queued #1 and #2, thanks!